List of Particle Arrays structure for ParticleSet - DO NOT MERGE - DO NOT CLOSE #884
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
the auto-testing probably won't work before a rebase (which is NOT to be done). |
| end_index = self._pid_mapping_bounds[bracket_index][2] | ||
| # while start_index<key: | ||
| # while end_index >= key: | ||
| while key >= end_index: |
Member
There was a problem hiding this comment.
This could be a bisect search on the end_index for speedier (log(N)) search
| c_double(dt), | ||
| *fargs) | ||
|
|
||
| for subfield_c in pset.particles_c: |
Member
There was a problem hiding this comment.
It's a bit confusing you call this subfield, because a Field is a specific object in Parcels, and I don't think that these subfields have anything to do with Fields
CKehl
force-pushed
the
list_of_pset_array_trials
branch
2 times, most recently
from
835d177 to
60875ef
Compare
CKehl
force-pushed
the
list_of_pset_array_trials
branch
3 times, most recently
from
3bcb825 to
7692103
Compare
CKehl
force-pushed
the
list_of_pset_array_trials
branch
3 times, most recently
from
104fcc8 to
b84615d
Compare
CKehl
force-pushed
the
list_of_pset_array_trials
branch
2 times, most recently
from
2d40dbe to
af8546d
Compare
CKehl
force-pushed
the
list_of_pset_array_trials
branch
from
af8546d to
b90a86b
Compare
CKehl
force-pushed
the
list_of_pset_array_trials
branch
from
d8ee80a to
128a5d5
Compare
CKehl
force-pushed
the
list_of_pset_array_trials
branch
2 times, most recently
from
0e3b871 to
04fb590
Compare
CKehl
force-pushed
the
list_of_pset_array_trials
branch
from
48de2c7 to
f2e02db
Compare
CKehl
force-pushed
the
list_of_pset_array_trials
branch
from
86f514d to
e551c1f
Compare
This was referenced Feb 9, 2021
…orking (stommel).
…he ParticleSet class.
…orking (stommel).
…he ParticleSet class.
…rray particles. TODO: particle file.
…e new pset (basically: change the iterator). structure to be wrapped up and tested now.
…orking (stommel).
…icleSet for element iteration - slow, but working.
…orking (stommel).
…orking (stommel).
CKehl
force-pushed
the
list_of_pset_array_trials
branch
from
fed7b63 to
ae1e349
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.