-
Notifications
You must be signed in to change notification settings - Fork 168
Implement Kernel hierarchy - generalize kernels #997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…nges in kernel.py (master) with kernelbase.py (sorted_lists_pset)
…led with a complete copy of kernel.py
… of BaseKernel base class
…soa.py that are already defined in basekernel.py
… KernelSOA.__radd__()
…t is inherited from BaseKernel)
…ed() function from KernelSOA to BaseKernel
…e issues emerging from running the tests. tested and working.
|
ready for review. If you're interested what I did: the commits are structured in a step-by-step way to better understand the changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good cleanup of the code. A few minor comments
- there seem to be a few stray commented lines (from debugging?) left in the code. Remove these for a cleaner code?
-
We previously moved all the particleset*.py files to a new subdirectory. Should we do the same for these kernel*.py files, for consistency? - Not sure why the CI on Windows is failing?
(a) first trying to trace and eradicate Win32 compile errors |
… if the path-composition for the library-file goes wrong on Windows.
… if the path-composition for the library-file goes wrong on Windows.
erikvansebille
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had some more time to carefully look through the changes, and have two slightly larger comments (sorry for not raising these earlier); as well as still a commented line of old code here and there that could go?
erikvansebille
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy with all the changes if the last two debug lines are removed. Feel free to merge after that
Based on the performance branches (#862 , #884 , #957 , #958 and #959 ) and in preparation for merging #958 , we estanlish a kernel hierarchy, with a base kernel (basekernel.py) from with
ParticleSet-specific derivatives and None-fieldset derivatives can derive from. The latter one is just meant for larger extension purposes, as a testbed-draft.This issue is linked with #862 (initial basekernel.py), #958 (target ParticleSet to be incorporated after changes), #866 (proper object-oriented programming) and #618 (earlier starting point).