Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctrl-C handling is generally unreliable #2174

Open
benclifford opened this issue Dec 28, 2021 · 0 comments
Open

Ctrl-C handling is generally unreliable #2174

benclifford opened this issue Dec 28, 2021 · 0 comments

Comments

@benclifford
Copy link
Collaborator

benclifford commented Dec 28, 2021

Describe the bug
When pressing ctrl-C in various situations, parsl tends to hang. This is especially obvious to me in pytest, one of the main environments in which I run parsl code.

For example, pressing ctrl-C in a recent pytest run has left pytest waiting for parsl to shut down before exiting, while the parsl strategy code continues to attempt to launch (failing) blocks to run its one outstanding job on htex, apparently forever.

Other misbehaviour happens with monitoring - for example, see issue #2123 with LSST.

In general, parsl's handling of shutdown like this is pretty poor and needs a serious review and fixup to ensure that the various component processes can cope with being killed by means other than successful execution shutdown.

benclifford added a commit that referenced this issue Mar 13, 2023
The join parameter should never be set by a user, and gives bad error
messages if it is set - see issue #2174.

The parameter was only there so that the join_app decorator could be
implemented in terms of the python_app decorator. This PR changes how
that implementation works so that this misbehaviour is not exposed
to end users.

Fixes issue #2174
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant