Fall back to load_incluster_config() when load_kube_config() fails #2503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is failing flake8 with: |
benclifford
reviewed
Dec 12, 2022
| config.load_kube_config() | ||
| try: | ||
| config.load_kube_config() | ||
| except: |
There was a problem hiding this comment.
This line is caught by flake8: it catches all exceptions.
In practice in parsl, this sort of thing has caused problems such as ctrl-C handling: #2174
Maybe it should be more narrowly kubernetes.config.config_exception.ConfigException
There was a problem hiding this comment.
Sounds reasonable.
|
@manning-ncsa You still working on this? Running into the same problem right now. |
|
@tcbonds No, I am not working on this anymore. Good luck! |
|
@benclifford myself and @trey-stafford are dealing with this today, and this looks simple enough for us to re-implement in a superceding PR so we're going to go for that :) |
|
closing because #3357 is a replacement |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See kubernetes-client/python#1005 for a good description of the issue.
Fixes # (issue)
Type of change
Choose which options apply, and delete the ones which do not apply.