Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display connecting line on Timeout as thinner line #398

Closed
dannycohen opened this issue Oct 6, 2014 · 5 comments · Fixed by #450
Closed

Display connecting line on Timeout as thinner line #398

dannycohen opened this issue Oct 6, 2014 · 5 comments · Fixed by #450
Assignees
Labels
Milestone

Comments

@dannycohen
Copy link

Display connecting line on Timeout as same line as thinner line than other message types (command, event)

@distantcam
Copy link
Contributor

And do the same for message flow?

@dannycohen
Copy link
Author

@distantcam - Yes.

Also note that in Message Flow, the tooltip should be indicating its a Timeout message, and not a Command:

image

(i.e. lets change the tooltip from "Sent Command" to "Scheduled Timeout")

// CC @udidahan

@distantcam distantcam modified the milestones: 1.2.1, 1.2.0, 1.2.2, 1.2.3 Oct 14, 2014
@distantcam distantcam removed this from the vNext milestone Nov 27, 2014
@dannycohen dannycohen removed this from the vNext milestone Nov 27, 2014
@johnsimons johnsimons assigned johnsimons and unassigned distantcam May 6, 2015
@johnsimons johnsimons added this to the 1.2.8 milestone May 6, 2015
@johnsimons
Copy link
Member

@dannycohen need your input regarding this issue, see #450 (comment)

@distantcam distantcam modified the milestone: 1.2.8 May 8, 2015
@dannycohen
Copy link
Author

@johnsimons - As discussed:
We need to provide consistent visual language across all view (e.g. dotted line for Event, full line for Command, and (now) thin line for Timeout)

@sergioc - Can you chime in on design guidelines ?

@sergioc
Copy link

sergioc commented May 11, 2015

@dannycohen will discuss during sync with @johnsimons tomorrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants