Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to flow diagram #450

Merged
merged 6 commits into from
May 29, 2015
Merged

Improvements to flow diagram #450

merged 6 commits into from
May 29, 2015

Conversation

johnsimons
Copy link
Member

Fixes #398

Here is what it looks like now:
image

And the tooltip is also updates see:
image

@johnsimons johnsimons self-assigned this May 6, 2015
@johnsimons johnsimons added this to the 1.2.8 milestone May 6, 2015
@johnsimons
Copy link
Member Author

@distantcam should the saga diagram line also be thinner ?
image

And the sequence diagram ?:
image

@sergioc
Copy link

sergioc commented May 13, 2015

@johnsimons the appearance of the lines should be consistent between the 3 diagrams. The timeout line should be 1px wide and use the color #666666.

This is how it should look like in the Sequence Diagram view (note that label also shows really close to connector line):

screenshot 2015-05-13 08 38 05

@johnsimons johnsimons changed the title Makes the timeout connection line thinner in Flow Diagram [WIP] Makes the timeout connection line thinner in Flow Diagram May 20, 2015
@johnsimons johnsimons changed the title [WIP] Makes the timeout connection line thinner in Flow Diagram [WIP] Improvements to diagrams May 20, 2015
@johnsimons johnsimons changed the title [WIP] Improvements to diagrams [WIP] Improvements to flow diagram May 21, 2015
@johnsimons johnsimons changed the title [WIP] Improvements to flow diagram Improvements to flow diagram May 21, 2015
@johnsimons johnsimons added this to the 1.2.9 milestone May 21, 2015
@johnsimons
Copy link
Member Author

@distantcam this one is ready to go.
I've decided to split further improvements to other diagrams as a different PR as this one already contains quite a few nice improvements

johnsimons added a commit that referenced this pull request May 29, 2015
Improvements to flow diagram
@johnsimons johnsimons merged commit 1beb55e into master May 29, 2015
@johnsimons johnsimons deleted the Issue_398 branch May 29, 2015 00:51
@johnsimons johnsimons modified the milestone: 1.2.9 Jun 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display connecting line on Timeout as thinner line
5 participants