Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix thread synchronization issues in master #607

Closed
HEskandari opened this issue Oct 25, 2016 · 4 comments
Closed

Fix thread synchronization issues in master #607

HEskandari opened this issue Oct 25, 2016 · 4 comments
Labels
Withdrawn

Comments

@HEskandari
Copy link
Contributor

There's a few threading issues with the latest build off the master:

  • When running on a customer database I end up in an infinite loop on startup. The code for refreshing the UI keeps running.
  • The WorkStarted/Finished events are received out of order so the main shell thinks there's a work in progress while there isn't. When this happens, it would not be possible to connect to another instance of ServiceControl as the menu grays out.

The issue is due to how events are marshalled between threads (background and main).
@adamralph adamralph changed the title Thread synchronization issues on the latest build off the master Fix thread synchronization issues in master Oct 25, 2016
@adamralph adamralph added this to the 1.5.8 milestone Oct 25, 2016
@HEskandari HEskandari added the Bug label Oct 28, 2016
HEskandari added a commit that referenced this issue Oct 31, 2016
@HEskandari
Removed the redundant notify change which causes infinite loops in ap…
71aca15 
…p startup on certain situations. Related to #607
distantcam pushed a commit that referenced this issue Nov 2, 2016
@HEskandari @distantcam
Removed the redundant notify change which causes infinite loops in ap…
ca98d22 
…p startup on certain situations. Related to #607
@distantcam
Copy link
Contributor

Fixed in the pirac merge.

@adamralph
Copy link
Member

Was this a problem in 1.5.7 or only in master? If the latter, we should remove the 1.5.8 milestone since the fix is irrelevant wrt to production versions.

@HEskandari
Copy link
Contributor Author

@adamralph this happened after releasing the 1.5.7. 👍 on removing the milestone.

@adamralph
Copy link
Member

We are reverting master to 1.5.7 in #617 so this bug effectively never existed.

@adamralph adamralph removed this from the 1.5.8 milestone Nov 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Withdrawn
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@HEskandari @adamralph @distantcam