Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade git version task #589

Merged
merged 4 commits into from
Jul 5, 2016
Merged

Downgrade git version task #589

merged 4 commits into from
Jul 5, 2016

Conversation

HEskandari
Copy link
Contributor

This downgrades GitVersionTask to 2.0.1 for ReleaseDate attribute to properly generate, without which, the app would not start.

@gbiellem
Copy link
Contributor

gbiellem commented Jul 4, 2016

@HEskandari Your downgrade only does the ServiceInsight proj. Looking at 5c39756 the Gitversion was bumped to 3.5.4 in both the Setup proj and ServiceInsight proj.

@HEskandari
Copy link
Contributor Author

@gbiellem pushed.

@gbiellem
Copy link
Contributor

gbiellem commented Jul 4, 2016

@HEskandari Looks good to me but I'm not pressing merge. I'm not one of the @Particular/serviceinsight-maintainers

@HEskandari
Copy link
Contributor Author

Self-merged, since no one did it :P

@HEskandari HEskandari deleted the DowngradeGitVersionTask branch July 5, 2016 03:16
@adamralph adamralph added this to the 1.5.7 milestone Dec 6, 2016
@adamralph
Copy link
Member

Added to 1.5.7 milestone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants