Fixes #613.

[HEskandari]

Doing a null check on the url SI connects to. Also doing that on OnInitialize to fix the auto-connect on startup issue.

---

Fixes #613

[HEskandari]

@Particular/serviceinsight-maintainers Please review.

[adamralph]

@HEskandari why was this tagged as being blocked?

[adamralph]

Would it be better to throw an exception in this case? I guess we're fixing the problem at the call site below?

[HEskandari]

Don't think so. This is called on application start as well which means if an exception is thrown the app will crash.

[adamralph]

The only usages I see are

• ServiceInsight/src/ServiceInsight/Shell/ServiceControlConnectionViewModel.cs

  Line 117 in 8747700

  connection.ConnectTo(serviceUrl);

  - this is protected because Uri.IsWellFormedUriString returns false when passed a null string.

• ServiceInsight/src/ServiceInsight/Shell/ShellViewModel.cs

  Line 167 in 8747700

  connectionProvider.ConnectTo(configuredConnection);

  - this is OK because GetConfiguredAddress cannot return null.

• ServiceInsight/src/ServiceInsight/Shell/ShellViewModel.cs

  Line 170 in 8747700

  connectionProvider.ConnectTo(existingConnection);

  - this is covered by this fix.

The code smell I'm detecting is the setting of the Url property to null and then avoiding the clearing of controls, refreshing etc. when that is the case. I guess the overall question is: does the behaviour of this method make sense when the passed in URL is null, in the context of the expectation of all consumers of this type?

[adamralph]

Removed the blocked tag. I'm not sure why it was added in the first place, but it seems redundant since a) the changes were merged and b) the changes were reverted in #617.

#613 is being re-fixed.