Skip to content

Conversation

@Saeldur
Copy link
Contributor

@Saeldur Saeldur commented Jan 21, 2025

Description of the problem being solved:

Increases Maximum Shock per stack to 100%, as you cannot set it above 20% currently in POB.

Link to a build that showcases this PR:

https://pobb.in/8gNhxMRJ7QWU

Before screenshot:

before

After screenshot:

after

@QuickStick123
Copy link
Contributor

You should probably just implement shock magnitude instead. But this may be a good stop gap measure. #432 (comment)

@Saeldur
Copy link
Contributor Author

Saeldur commented Jan 21, 2025

You should probably just implement shock magnitude instead. But this may be a good stop gap measure. #432 (comment)

Yeah, ideally that gets done but this is at least a stop gap measure to allow people to manually override it until someone updates Ailment calculations. I had a (brief) look but it seems beyond my ability to work out how to do it in a neat fashion in a short time unfortunately due to unfamiliarity with the codebase.

This is required to increase Shock Maximum to the ingame value even without the further improvements though.

@LocalIdentity
Copy link
Contributor

Superseded by #628

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants