-
Notifications
You must be signed in to change notification settings - Fork 221
Add Support for Ailment chance calculations and Fix Shock calculation #628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Support for Ailment chance calculations and Fix Shock calculation #628
Conversation
- canDoAilment is currently unconditionally returning false - possible bug with calcAverageSourceDamage ?
…stack value (didn't match breakdown values)
1. Make effective DPS visible again 2. Make damage per stack visible again (renamed to "Dmg./<ailment> Stack" for clarity)
9a226b4 to
ce2ce4d
Compare
|
Updated PR description to accurately reflect changes |
LocalIdentity
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bunch of small things to change but I will take care of a lot of them as I am working on fixing them now
In general, try to keep the formatting of coding similar to existing sections
If you're removing code related to PoE 1, do it in a separate PR so it is easy for us to revert it if GGG decide to add it back in for PoE 2
If mechanics don't work in a section you can leave a small comment and link it to an issue you've made
Use EmmyLua annotations for function comments so they can be seen when calling the function
Remove print statements Remove close range knockback remove output requirements for functions Fix comment typos
Uses game constants for values

Old PR: #434 (not the same PR due to fork shenanigans)
No issue fixes yet, might help with #178 though. Pushed early to avoid work duplication conflicts with other devs.
Description of the problem being solved:
Steps taken to verify a working solution:
Implementation notes / stuff to still be done in future patches
canDoAilmentcausingcalcAilmentSourceDamageto unconditionally return 0 damage.Link to a build that showcases this PR:
I made an Ailment Demo project which applies the following effects:
Before screenshot:
After screenshot: