Update "Dmg. per ailment" title and ailment DPS beakdown titles #569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pauloday
force-pushed
the
correct-dmg-per-ailment
branch
from
2c798c4 to
445568e
Compare
pauloday
force-pushed
the
correct-dmg-per-ailment
branch
from
445568e to
00086d0
Compare
Contributor
Author
|
This may not be ready yet, not sure if the effective damage is taken into account for the new calculation. |
Updated "Dmg. per {ailment}" row in calcs tab to "Dmg. of all
{ailment}s"
Also updated "Total damage" and "Average ailment DPS" titles in
breakdown of "{ailment} DPS" row tp "Total damage per {ailment}" and
"Average {ailment} DPS"
pauloday
force-pushed
the
correct-dmg-per-ailment
branch
from
00086d0 to
053b83a
Compare
pauloday
changed the title
deathbeam
approved these changes
Jan 24, 2025
LocalIdentity
approved these changes
Jan 27, 2025
LocalIdentity
merged commit f49266e
into
PathOfBuildingCommunity:dev
1 of 2 checks passed
Contributor
|
Nice first PR |
OrderedSet86
added a commit
to OrderedSet86/PathOfBuilding-PoE2
that referenced
this pull request
Jan 27, 2025
LocalIdentity
pushed a commit
that referenced
this pull request
Feb 10, 2025
…#628) * Add notes for poe2 ailment threshold implementation, remove poe1 scorch * Partial progress towards ailment threshold - canDoAilment is currently unconditionally returning false - possible bug with calcAverageSourceDamage ? * Fix bugs in last commit, reorganize calc tab, temporarily remove per stack value (didn't match breakdown values) * Cleanup for PR * Remove leftover ConPrintf values * Implement @deathbeam feedback 1. Make effective DPS visible again 2. Make damage per stack visible again (renamed to "Dmg./<ailment> Stack" for clarity) * Remove rebase leftovers * Fix typo bug added in #569 * Remove ailment threshold from bleed * Fix Nightblade feedback (modname -> modName) * Fix PR part 1 Remove print statements Remove close range knockback remove output requirements for functions Fix comment typos * Fix CalcSections * Add back Impale Block * Update enemy ailment threshold values Uses game constants for values * Formatting * Shock chance calcs * Fix base Shock value * Remove unneeded comment and move to data.lua * Fix Ailment Magnitude not working correctly * Fix Ailment Threshold value on bosses * Implement Minimum Chill values * Fix Current shock for Stormweaver node * Fix breakdowns --------- Co-authored-by: LocalIdentity <localidentity2@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #565
Description of the problem being solved:
Make the title of "Dmg. per (Poison/Bleed/Ignite)" more clear. Also change titles in the "(Poison/Bleed/Ignite) DPS" to be more specific.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://maxroll.gg/poe2/pob/1kmu90yp
Before screenshot:
After screenshot: