Fix Crash when switching between multiple choice Ascendancies #597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tions Fixes a possible crash (PathOfBuildingCommunity#575) when a node `allocMode` is set to `nil`, which breaks generating the modlist in `CalcSetup.lua`
LocalIdentity
approved these changes
Jan 27, 2025
LocalIdentity
changed the title
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a possible crash (#575) when a node
allocModeis set tonil, which breaks generating the modlist inCalcSetup.luaFixes #575 .
Description of the problem being solved:
When multiple choice passives are deallocated,
allocModewas being set tonil, which breaks how modlists are generated for weapon sets in CalcSetup.lua:310.Steps taken to verify a working solution:
Projectile Proximity Specializationand one ofFar ShotorPoint Blank. Hover over the other.allocMode=0DeallocSingleNodeperforms the same changes to the node data as the deleted lines in this change (and would also handle a multiple choice mastery, if that ever happened)Before screenshot:
After screenshot: