Skip to content

Conversation

@nessgor
Copy link
Contributor

@nessgor nessgor commented Feb 8, 2025

(%d.+) is incorrect for decimals. It should be ([%d%.]+).

Fixes #614.

Description of the problem being solved:

Steps taken to verify a working solution:

  • Tested manually on POB2
  • Automatic tests successful

Link to a build that showcases this PR:

This can be reproduced with an empty build

Before screenshot:

image

After screenshot:

image

(%d.+) is incorrect for decimal. It should be ([%d%.]+).
@LocalIdentity LocalIdentity changed the title fix: wrong string match pattern Fix crash from importing item with Mana leech mods Feb 8, 2025
@LocalIdentity LocalIdentity added the crash Causes PoB to crash and is High Priority label Feb 8, 2025
@LocalIdentity LocalIdentity merged commit 721a803 into PathOfBuildingCommunity:dev Feb 8, 2025
2 checks passed
@nessgor nessgor deleted the crash-when-trying-to-paste-item-stats-from-trade-window branch February 9, 2025 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

crash Causes PoB to crash and is High Priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crash when trying to paste item stats from trade window

2 participants