Fix Stat descriptions on gem tooltips and crit node on tree #909
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `table_only` entries in the stat description files are not needed afaik and they cause issues with the order of stats With them removed we can revert the fix in StatDescriber, as that also causes issues for stats that have multiple entries Fixes the tree export for `Critical Damage Bonus against Enemies that are on Full Life` as that previously had a `table_only` value as the first stat description which was causing an issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
table_onlyentries in the stat description files are not needed afaik and they cause issues with the order of statsWith them removed we can revert the fix in StatDescriber, as that also causes issues for stats that have multiple entries
Fixes the tree export for
Critical Damage Bonus against Enemies that are on Full Lifeas that previously had atable_onlyvalue as the first stat description which was causing an issueFixes #903