Skip to content

Fix Stat descriptions on gem tooltips and crit node on tree #909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2025
Merged

Fix Stat descriptions on gem tooltips and crit node on tree #909

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Data/ModCache.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1038,6 +1038,7 @@ c["100% increased Block chance against Projectiles"]={{[1]={flags=0,keywordFlags
c["100% increased Chance to be afflicted by Ailments when Hit"]={{}," Chance to be afflicted by Ailments when Hit "}
c["100% increased Chance to be afflicted by Ailments when Hit 20% increased Movement Speed while affected by an Ailment"]={{[1]={[1]={type="Condition",varList={[1]="Bleeding",[2]="Poisoned",[3]="Ignited",[4]="Chilled",[5]="Frozen",[6]="Shocked",[7]="Electrocuted"}},flags=0,keywordFlags=0,name="MovementSpeed",type="INC",value=100}}," Chance to be afflicted by Ailments when Hit 20% increased "}
c["100% increased Cold Damage"]={{[1]={flags=0,keywordFlags=0,name="ColdDamage",type="INC",value=100}},nil}
c["100% increased Critical Damage Bonus against Enemies that are on Full Life"]={{[1]={[1]={actor="enemy",type="ActorCondition",var="FullLife"},flags=0,keywordFlags=0,name="CritMultiplier",type="INC",value=100}},nil}
c["100% increased Critical Hit Chance"]={{[1]={flags=0,keywordFlags=0,name="CritChance",type="INC",value=100}},nil}
c["100% increased Critical Hit Chance against Enemies on Full Life"]={{[1]={[1]={actor="enemy",type="ActorCondition",var="FullLife"},flags=0,keywordFlags=0,name="CritChance",type="INC",value=100}},nil}
c["100% increased Culling Strike Threshold"]={{}," Culling Strike Threshold "}
Expand Down Expand Up @@ -2162,6 +2163,7 @@ c["40% increased Chill Duration on Enemies"]={{[1]={flags=0,keywordFlags=0,name=
c["40% increased Cold Damage"]={{[1]={flags=0,keywordFlags=0,name="ColdDamage",type="INC",value=40}},nil}
c["40% increased Cooldown Recovery Rate"]={{[1]={flags=0,keywordFlags=0,name="CooldownRecovery",type="INC",value=40}},nil}
c["40% increased Critical Damage Bonus"]={{[1]={flags=0,keywordFlags=0,name="CritMultiplier",type="INC",value=40}},nil}
c["40% increased Critical Damage Bonus against Enemies that are on Full Life"]={{[1]={[1]={actor="enemy",type="ActorCondition",var="FullLife"},flags=0,keywordFlags=0,name="CritMultiplier",type="INC",value=40}},nil}
c["40% increased Critical Damage Bonus with One Handed Melee Weapons"]={{[1]={flags=21474836484,keywordFlags=0,name="CritMultiplier",type="INC",value=40}},nil}
c["40% increased Critical Damage Bonus with Spears"]={{[1]={flags=268435460,keywordFlags=0,name="CritMultiplier",type="INC",value=40}},nil}
c["40% increased Critical Hit Chance"]={{[1]={flags=0,keywordFlags=0,name="CritChance",type="INC",value=40}},nil}
Expand Down Expand Up @@ -3613,8 +3615,6 @@ c["Converts all Energy Shield to Mana"]={{[1]={flags=0,keywordFlags=0,name="Ener
c["Converts all Evasion Rating to Armour"]={{[1]={flags=0,keywordFlags=0,name="IronReflexes",type="FLAG",value=true},[2]={flags=0,keywordFlags=0,name="EvasionConvertToArmour",type="BASE",value=100}},nil}
c["Corrupted Blood cannot be inflicted on you"]={{[1]={flags=0,keywordFlags=0,name="CorruptedBloodImmune",type="FLAG",value=true}},nil}
c["Creates Consecrated Ground on use"]={{},nil}
c["Critical Damage Bonus vs full life enemies 100%"]={nil,"Critical Damage Bonus vs full life enemies 100% "}
c["Critical Damage Bonus vs full life enemies 40%"]={nil,"Critical Damage Bonus vs full life enemies 40% "}
c["Critical Hits Ignore Enemy Monster Lightning Resistance"]={{[1]={[1]={type="Condition",var="CriticalStrike"},flags=0,keywordFlags=0,name="IgnoreLightningResistance",type="FLAG",value=true}},nil}
c["Critical Hits Poison the enemy"]={nil,"Critical Hits Poison the enemy "}
c["Critical Hits cannot Extract Impale"]={nil,"Critical Hits cannot Extract Impale "}
Expand Down
8 changes: 0 additions & 8 deletions src/Data/ModScalability.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7351,7 +7351,6 @@ return {
["Cremation can have up to # additional Geysers at a time"] = { { isScalable = true } },
["Crimson Assault"] = { },
["Crimson Dance"] = { },
["Critical Damage Bonus vs full life enemies #%"] = { { isScalable = true } },
["Critical Hit Chance is #% for Hits with this Weapon"] = { { isScalable = true } },
["Critical Hit Chance is increased by Lightning Resistance"] = { },
["Critical Hit Chance is increased by Overcapped Lightning Resistance"] = { },
Expand Down Expand Up @@ -7538,7 +7537,6 @@ return {
["Deals # to # Physical Damage"] = { { isScalable = true }, { isScalable = true } },
["Deals #% of current Mana as Chaos Damage to you when Effect ends"] = { { isScalable = true } },
["Deals base Chaos Damage equal to #% of your Current Mana"] = { { isScalable = true } },
["Death delay at 0 Life #s"] = { { isScalable = true, formats = { "milliseconds_to_seconds" } } },
["Debilitate Enemies for # Seconds when you Suppress their Spell Damage"] = { { isScalable = true, formats = { "milliseconds_to_seconds_2dp_if_required" } } },
["Debilitate Enemies for 1 second on Hit"] = { },
["Debilitate nearby Enemies for # Seconds when Effect ends"] = { { isScalable = true } },
Expand Down Expand Up @@ -9066,7 +9064,6 @@ return {
["Ignite on Enemies you Kill Spreads to other Enemies within # metres"] = { { isScalable = false, formats = { "divide_by_ten_1dp_if_required" } } },
["Ignited Enemies Burn #% slower"] = { { isScalable = true } },
["Ignited Enemies Killed by your Hits are destroyed"] = { },
["Ignites enemies within #m radius as though dealing # Fire damage"] = { { isScalable = true, formats = { "divide_by_ten_1dp_if_required" } }, { isScalable = true } },
["Ignites you cause are reflected back to you"] = { },
["Ignites you inflict deal Damage #% faster"] = { { isScalable = true } },
["Ignites you inflict spread to other Enemies that stay within # metre for 2 seconds"] = { { isScalable = true, formats = { "divide_by_ten_1dp_if_required" } } },
Expand Down Expand Up @@ -9727,7 +9724,6 @@ return {
["Maximum Critical Hit Chance is 50%"] = { },
["Maximum Energy Shield is zero"] = { },
["Maximum Life of Summoned Elemental Golems is Doubled"] = { },
["Maximum Life taken as Fire damage per second #%"] = { { isScalable = true, formats = { "per_minute_to_per_second" } } },
["Maximum Mana is replaced by Maximum Infernal Flame\nGain Infernal Flame instead of spending Mana for Skill costs"] = { },
["Maximum Physical Damage Reduction is 50%"] = { },
["Maximum Power Charges is 0"] = { },
Expand Down Expand Up @@ -10235,9 +10231,6 @@ return {
["Monsters' Melee Attacks apply random Hexes on Hit"] = { },
["Monsters' Projectiles always Pierce"] = { },
["Monsters' skills Chain # additional times"] = { { isScalable = true } },
["More Elemental Ailment buildup while Unbound #%"] = { { isScalable = true } },
["More Elemental Ailment chance while Unbound #%"] = { { isScalable = true } },
["More Elemental Damage while Unbound #%"] = { { isScalable = true } },
["Movement Attack Skills have #% increased Attack Speed"] = { { isScalable = true } },
["Movement Attack Skills have #% reduced Attack Speed"] = { { isScalable = true, formats = { "negate" } } },
["Movement Skills Cost no Mana"] = { },
Expand Down Expand Up @@ -12615,7 +12608,6 @@ return {
["Unattached Brands gain #% increased Brand Attachment Range per second, up to 100%"] = { { isScalable = true } },
["Unattached Brands gain #% reduced Brand Attachment Range per second"] = { { isScalable = true, formats = { "negate" } } },
["Unblockable"] = { },
["Unbound Fury gain interval per Ailment 0.2s"] = { },
["Undead Minions count as Demons"] = { },
["Undead Minions have #% increased Reservation"] = { { isScalable = true } },
["Undead Minions have #% reduced Reservation"] = { { isScalable = true, formats = { "negate" } } },
Expand Down
13 changes: 0 additions & 13 deletions src/Data/StatDescriptions/Specific_Skill_Stat_Descriptions/add_buff_to_target.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,19 +24,6 @@ return {
},
[2]={
[1]={
[1]={
[1]={
k="milliseconds_to_seconds_2dp_if_required",
v=1
},
limit={
[1]={
[1]="#",
[2]="#"
}
},
text="Regeneration duration {0}s"
}
},
stats={
[1]="skill_effect_duration"
Expand Down
35 changes: 0 additions & 35 deletions src/Data/StatDescriptions/Specific_Skill_Stat_Descriptions/advancing_strike.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,19 +9,6 @@ return {
},
[2]={
[1]={
[1]={
[1]={
k="divide_by_ten_1dp_if_required",
v=1
},
limit={
[1]={
[1]="#",
[2]="#"
}
},
text="Explosion radius {0}m"
}
},
stats={
[1]="active_skill_area_of_effect_radius"
Expand Down Expand Up @@ -106,15 +93,6 @@ return {
[4]={
[1]={
[1]={
limit={
[1]={
[1]="#",
[2]="#"
}
},
text="Additional Physical Attack Damage from Blood Loss {0}%"
},
[2]={
limit={
[1]={
[1]="#",
Expand All @@ -131,19 +109,6 @@ return {
[5]={
[1]={
[1]={
limit={
[1]={
[1]="#",
[2]="#"
},
[2]={
[1]="#",
[2]="#"
}
},
text="More area of effect per {1} Blood Loss Consumed {0}% (max 500%)"
},
[2]={
limit={
[1]={
[1]="#",
Expand Down
13 changes: 0 additions & 13 deletions src/Data/StatDescriptions/Specific_Skill_Stat_Descriptions/ailment_bearer.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,19 +37,6 @@ return {
},
[2]={
[1]={
[1]={
[1]={
k="milliseconds_to_seconds_2dp_if_required",
v=1
},
limit={
[1]={
[1]="#",
[2]="#"
}
},
text="Unbound duration {0}s"
}
},
stats={
[1]="skill_effect_duration"
Expand Down
22 changes: 0 additions & 22 deletions src/Data/StatDescriptions/Specific_Skill_Stat_Descriptions/alchemist_boon.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,6 @@ return {
[1]={
[1]={
[1]={
limit={
[1]={
[1]="#",
[2]="#"
}
},
text="Flask recovery granted to Allies {0}%"
},
[2]={
limit={
[1]={
[1]="#",
Expand All @@ -30,19 +21,6 @@ return {
[2]={
[1]={
[1]={
[1]={
k="per_minute_to_per_second_2dp_if_required",
v=1
},
limit={
[1]={
[1]="#",
[2]="#"
}
},
text="Flask charges per second {0}"
},
[2]={
[1]={
k="per_minute_to_per_second_2dp_if_required",
v=1
Expand Down
18 changes: 0 additions & 18 deletions src/Data/StatDescriptions/Specific_Skill_Stat_Descriptions/archmage.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,31 +40,13 @@ return {
},
[3]={
[1]={
[1]={
limit={
[1]={
[1]="#",
[2]="#"
}
},
text="Non-Channelling Spell additional Mana cost {0}"
}
},
stats={
[1]="archmage_non_channelled_spell_mana_cost_+"
}
},
[4]={
[1]={
[1]={
limit={
[1]={
[1]="#",
[2]="#"
}
},
text="Non-Channelling Spell damage Gained as Lightning {0}%"
}
},
stats={
[1]="archmage_all_damage_%_to_gain_as_lightning_to_grant_to_non_channelling_spells"
Expand Down
13 changes: 0 additions & 13 deletions src/Data/StatDescriptions/Specific_Skill_Stat_Descriptions/armour_explosion.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,19 +4,6 @@
return {
[1]={
[1]={
[1]={
[1]={
k="divide_by_ten_1dp_if_required",
v=1
},
limit={
[1]={
[1]="#",
[2]="#"
}
},
text="Explosion radius {0}m"
}
},
stats={
[1]="active_skill_area_of_effect_radius"
Expand Down
13 changes: 0 additions & 13 deletions src/Data/StatDescriptions/Specific_Skill_Stat_Descriptions/artillery_ballista_projectile.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,19 +37,6 @@ return {
},
[2]={
[1]={
[1]={
[1]={
k="divide_by_ten_1dp_if_required",
v=1
},
limit={
[1]={
[1]="#",
[2]="#"
}
},
text="Bolt explosion radius {0}m"
}
},
stats={
[1]="active_skill_secondary_area_of_effect_radius"
Expand Down
22 changes: 0 additions & 22 deletions src/Data/StatDescriptions/Specific_Skill_Stat_Descriptions/attrition.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,6 @@ return {
[1]={
[1]={
[1]={
limit={
[1]={
[1]="#",
[2]="#"
}
},
text="Culling Strike time in Presence requirement {0}s"
},
[2]={
limit={
[1]={
[1]="#",
Expand All @@ -30,19 +21,6 @@ return {
[2]={
[1]={
[1]={
limit={
[1]={
[1]=1,
[2]="#"
},
[2]={
[1]=1,
[2]="#"
}
},
text="Hit damage for every 2 seconds in Presence (max) {0}% ({1}%)"
},
[2]={
limit={
[1]={
[1]=1,
Expand Down
28 changes: 1 addition & 27 deletions src/Data/StatDescriptions/Specific_Skill_Stat_Descriptions/aura_crit_against_enemy.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,19 +38,6 @@ return {
[2]={
[1]={
[1]={
[1]={
k="milliseconds_to_seconds_2dp_if_required",
v=1
},
limit={
[1]={
[1]="#",
[2]="#"
}
},
text="Critical Weakness frequency {0}s"
},
[2]={
[1]={
k="milliseconds_to_seconds_2dp_if_required",
v=1
Expand All @@ -63,7 +50,7 @@ return {
},
text="Applies Critical Weakness to enemies every {0} second"
},
[3]={
[2]={
[1]={
k="milliseconds_to_seconds_2dp_if_required",
v=1
Expand All @@ -83,19 +70,6 @@ return {
},
[3]={
[1]={
[1]={
[1]={
k="milliseconds_to_seconds_2dp_if_required",
v=1
},
limit={
[1]={
[1]="#",
[2]="#"
}
},
text="Critical Weakness duration {0}s"
}
},
stats={
[1]="skill_effect_duration"
Expand Down
Loading