Skip to content

Commit

Permalink
Fixes Rupture using the wrong stat for damage taken and Bleed duration (
Browse files Browse the repository at this point in the history
#8030)

* damage_taken and expire_rate were inversed, resulting in wrong effective dps modifier

* fix for incorrect "quicker bleedd" from rupture

* forgot to change rupture duration type to match the calculation

* Update CalcOffence.lua

* Fix Export

---------

Co-authored-by: LocalIdentity <31035929+LocalIdentity@users.noreply.github.com>
Co-authored-by: LocalIdentity <localidentity2@gmail.com>
  • Loading branch information
3 people authored Jul 30, 2024
1 parent 0f2a593 commit 6ed2c79
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions src/Data/Skills/sup_dex.lua
Original file line number Diff line number Diff line change
Expand Up @@ -3133,10 +3133,10 @@ skills["SupportRupture"] = {
excludeSkillTypes = { },
statDescriptionScope = "gem_stat_descriptions",
statMap = {
["support_rupture_bleeding_time_passed_+%_final"] = {
["support_rupture_bleeding_damage_taken_+%_final"] = {
mod("DamageTaken", "MORE", nil, 0, KeywordFlag.Bleed, { type = "GlobalEffect", effectType = "Debuff" }, { type = "Multiplier", var = "RuptureStack", limit = 3 })
},
["support_rupture_bleeding_damage_taken_+%_final"] = {
["support_rupture_bleeding_time_passed_+%_final"] = {
mod("BleedExpireRate", "MORE", nil, 0, KeywordFlag.Bleed, { type = "GlobalEffect", effectType = "Debuff" }, { type = "Multiplier", var = "RuptureStack", limit = 3 })
},
["critical_strikes_that_inflict_bleeding_also_rupture"] = {
Expand Down
4 changes: 2 additions & 2 deletions src/Export/Skills/sup_dex.txt
Original file line number Diff line number Diff line change
Expand Up @@ -376,10 +376,10 @@ local skills, mod, flag, skill = ...

#skill SupportRupture
statMap = {
["support_rupture_bleeding_time_passed_+%_final"] = {
["support_rupture_bleeding_damage_taken_+%_final"] = {
mod("DamageTaken", "MORE", nil, 0, KeywordFlag.Bleed, { type = "GlobalEffect", effectType = "Debuff" }, { type = "Multiplier", var = "RuptureStack", limit = 3 })
},
["support_rupture_bleeding_damage_taken_+%_final"] = {
["support_rupture_bleeding_time_passed_+%_final"] = {
mod("BleedExpireRate", "MORE", nil, 0, KeywordFlag.Bleed, { type = "GlobalEffect", effectType = "Debuff" }, { type = "Multiplier", var = "RuptureStack", limit = 3 })
},
["critical_strikes_that_inflict_bleeding_also_rupture"] = {
Expand Down

0 comments on commit 6ed2c79

Please sign in to comment.