Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Rupture using the wrong stat for damage taken and Bleed duration #8030

Merged
merged 5 commits into from
Jul 30, 2024

Conversation

dreais
Copy link
Contributor

@dreais dreais commented Jul 30, 2024

Description of the problem being solved:

Rupture support has 2 mods:

  • up to 29% more dmg taken per Rupture stack
  • 25% quicker bleed on enemy per Rupture

Currently, the "more dmg taken" mod is inversed with the "quicker bleed" numerically, and only goes up to 75%.

For the quicker bleed, I'm not sure where exactly this is calculated but 75% quicker shouldn't mean a 29% duration as this is the case in POB

Steps taken to verify a working solution:

  • Opened the same build and checked that both the more damage taken and duration matched the proper calculation

Link to a build that showcases this PR:

https://pobb.in/91FAzNjlHslt

Before screenshot:

image

image

After screenshot:

image

image

@Paliak Paliak added the bug: calculation Numerical differences label Jul 30, 2024
@LocalIdentity LocalIdentity changed the title Fixes to incorrect Rupture support calculation Fixes Rupture using the wrong stat for damage taken and Bleed duration Jul 30, 2024
@LocalIdentity LocalIdentity merged commit 6ed2c79 into PathOfBuildingCommunity:dev Jul 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: calculation Numerical differences
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants