Fix Trader memoryleak caused by OnFrame functions (#5473)

* fix(pobtrader): memoryleak caused by unsubbed OnFrame functions * style(pobtrader): fix indentation
PathOfBuildingCommunity · Dec 28, 2022 · cdd6fe2 · cdd6fe2
1 parent bfc5eb8
commit cdd6fe2
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/src/Classes/TradeQuery.lua b/src/Classes/TradeQuery.lua
@@ -39,9 +39,9 @@ local TradeQueryClass = newClass("TradeQuery", function(self, itemsTab)
 	self.pbLeagueIndex = 1
 
 	self.tradeQueryRequests = new("TradeQueryRequests", self)
-	table.insert(main.onFrameFuncs, function()
+	main.onFrameFuncs["TradeQueryRequests"] = function()
 		self.tradeQueryRequests:ProcessQueue()
-	end)
+	end
 
 	-- set 
 	self.storedGlobalCacheDPSView = GlobalCache.useFullDPS
@@ -185,7 +185,9 @@ end
 -- Opens the item pricing popup
 function TradeQueryClass:PriceItem()
 	self.tradeQueryGenerator = new("TradeQueryGenerator", self)
-
+	main.onFrameFuncs["TradeQueryGenerator"] = function()
+		self.tradeQueryGenerator:OnFrame()
+	end
 	-- Count number of rows to render
 	local row_count = 3 + #baseSlots
 	-- Count sockets

diff --git a/src/Classes/TradeQueryGenerator.lua b/src/Classes/TradeQueryGenerator.lua
@@ -77,9 +77,6 @@ local TradeQueryGeneratorClass = newClass("TradeQueryGenerator", function(self,
 	self.itemsTab = queryTab.itemsTab
 	self.calcContext = { }
 
-    table.insert(main.onFrameFuncs, function()
-        self:OnFrame()
-    end)
 end)
 
 local function fetchStats()