Fix Trader memoryleak caused by OnFrame functions #5473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dullson
changed the title
LocalIdentity
approved these changes
Dec 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5472
Some PoB Trader modules are causing memory leaks by leaving OnFrame references behind in the main module.
This fix converts OnFrame subscription to be named, allowing the new class instantiation to replace the old OnFrame reference.
This doesn't solve the dangling reference problem altogether, we still hold one reference each to these classes which potentially prevents GC. Still, reserving memory for only one object is better than a growing memory leak.
Feel free to override if you implement proper lifecycle management.