Fix Explosive Arrow Full DPS #5432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This relates to #2486 (though I'm still unclear exactly how). |
|
I think explosiveArrowFunc() would be a more reasonable name no need for weirdness |
Good call. This should also work for Barrage Support now, which fixes #2486. |
|
You have some conflict you need to fix @AnSq. |
Lilylicious
reviewed
Aug 13, 2023
|
|
||
| local barrageProjectiles = nil | ||
| if skillModList:Flag(nil, "SequentialProjectiles") and not skillModList:Flag(nil, "OneShotProj") and not skillModList:Flag(nil,"NoAdditionalProjectiles") and not skillModList:Flag(nil, "TriggeredBySnipe") then | ||
| barrageProjectiles = skillModList:Sum("BASE", skillCfg, "ProjectileCount") |
There was a problem hiding this comment.
Suggested change
| barrageProjectiles = skillModList:Sum("BASE", skillCfg, "ProjectileCount") | |
| barrageProjectiles = skillModList:Sum("BASE", activeSkill.skillCfg, "ProjectileCount") |
Without specifying the config properly, you're missing some projectiles.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2486
Description of the problem being solved:
When "Include in Full DPS" is checked for Explosive Arrow, currently PoB doesn't give it any special treatment and simply takes the "Average Damage" (of an explosion) times Attack Rate (the rate that you apply fuses) to get DPS. The correct calculation is Average Damage times Explosion Rate. This change implements a calculation for Explosion Rate, shown as "Hit Rate" in PoB.
The time between explosions (HitTime) is either the skill duration, or the time it take to reach the fuse limit, whichever is lower. The time to max fuses is:
The calculation is done in
explosiveArrowFunc(), which lives on the skill itself and kinda looks like a preFunc, but it needs access to information that's not available to the preFuncs. I also pulled the Maximum Sustainable Fuses calculation into this new function.Screenshots
Link to a build that showcases this PR:
This is the build used in the above screenshots: https://pobb.in/m4qGXNAjPT89