Explosive arrow accuracy improvements #6302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lilylicious
force-pushed
the
explosiveArrowFixes
branch
from
4927f07 to
d6b527f
Compare
|
Might be related #5432. |
This reverts commit d6b527f.
|
Removed the breakdown portion for now to instead handle that separately after #5432 is merged. |
|
Decided to add the breakdown portion back in, but now based on the work done in #5432. Merge that first. |
Lilylicious
force-pushed
the
explosiveArrowFixes
branch
from
2f72b08 to
34c9011
Compare
Lilylicious
force-pushed
the
explosiveArrowFixes
branch
from
34c9011 to
e6a09e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5738
Edit: Removed in favour of waiting until after #5432 is mergedEdit 2: Now depends on #5432
Description of the problem being solved:
There was a bug in explosive arrow that significantly overvalued added base damage. It was adding a 100% more multiplier to the skill per fuse, when it should have added the explosion's base damage again per fuse. This fix causes significant damage changes for builds that invested heavily in added base damage, but insignificant changes to builds that instead focused on attack speed.
I also added a breakdown for max sustainable fuses and a section for explosions per second.Edit: Removed in favour of waiting until after #5432 is mergedSteps taken to verify a working solution:
Link to a build that showcases this PR:
https://pobb.in/GdkJy8Pw4z0m