Only show # of poisons on enemy config if needed #5701
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lock showing # of poison on enemy config option behind ifEnemyMult PoisonStack just like # of poisons on self. Signed-off-by: Tomas Slusny <slusnucky@gmail.com>
deathbeam
added a commit
to deathbeam/PathOfBuilding-1
that referenced
this pull request
Feb 21, 2023
Same as PathOfBuildingCommunity#5701, this config option doesnt do anything by default and should be shown only if there is check if enemy is bleeding or not. Signed-off-by: Tomas Slusny <slusnucky@gmail.com>
QuickStick123
added
user-interface
|
#5712 in the end decided to include this change here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lock showing # of poison on enemy config option behind ifEnemyMult PoisonStack just like # of poisons on self.
Description of the problem being solved:
Config options should not be shown by default when they do nothing. The poison stack config option should only appear when there is relevant multiplier or condition it will fulfill.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://pobb.in/UrCgykdZKTSz