-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide config options that can be hidden by default behind conditions #5712
Hide config options that can be hidden by default behind conditions #5712
Conversation
9f186af
to
a4815f2
Compare
Also added hiding for "disable ehp gain on block" only if there are on block mods present |
a4815f2
to
1eb9f27
Compare
Also added support for hiding:
And changed all the ifXList to support type checking the value and treating lists correctly as list of OR checks. This also applies to all ifX options not to just specific ones with ifXList support |
1eb9f27
to
a7006e5
Compare
Added also hiding for enemyCorpseLife. This is last of the "relatively easy to hide" config options that I found I think. |
3ed7983
to
731a8d6
Compare
that config option also disables on suppress as well, so needs to show if those are in build |
731a8d6
to
2c08cc8
Compare
Ah completely missed that, updated (also updated the label and tooltip of the option to also mention suppress while at it) |
2c08cc8
to
af4f947
Compare
Will there be some mechanism to override/show all this? |
Not planning anything like that for this PR at least. But also all of the option this PR is hiding do not do anything when checked anyway except the crit lucky one without them actually enabling anything that is already in the build, so I dont rly see the need either |
Oh OK, carry on then! 👍 |
d2182c5
to
01525d5
Compare
a4338b1
to
8a29700
Compare
Another additions:
|
8a29700
to
99f4699
Compare
Added autohiding for new "Don't disable items" config option, now it only shows if there are items that are disabling anything (from #5664) |
Config changes: - Remove "Is your Crit Chance Lucky?" - The only sources can already be enabled with existing conditions and the lucky is implied after that (Blood Sacrament, Focus Mod, Dance with Death) - Only show "# of times skill has chained" if there is condition behind it (Gloomfang for example) - Only show "# of times skill has pierced" if there is condition behind it (Drillneck for example) - Only show "melee distance to enemy" if there is stat that depends on melee proximity (Close Combat, Slayer for example) - Only show "projectile travel distance if there is stat that depends on distance ramp (Point Blank, Longshot for example) - Only show "is enemy bleeding" if there is condition behind it (Bloodletting for example) - Only show "# of poison on enemy" if there is condition behind it (Vile Toxins for example)A - Only show "is the enemy maimed" if there is condition behind it (Maim support for example) - Only show "is enemy burning" if there is condition behind it - Only show "is enemy ignited" if there is condition behind it (Snowforged for example) - Only show "is enemy frozen" if there is condition behind it - Only show "effect of shock" if enemy is shocked - Only show "is enemy on consecrated ground" if there is condition behind it (Bottled Faith for example) - Only show "disable ehp gain on block" if there are any on block effects - Only show "life regen mode" if there is effect that depends on it (Enduring Cry etc) - Only show "armour calculation mode" if there is effect that depends on it (armour mastery etc) - Only show "enemy corpse life" if there is skill that depends on it (Cremation, Detonate Dead) - Only show "# of summoned totems" if there is perstat or enemy mult that depends on it - Only show "is enemy moving" if player has bleedchance - Only show "Don't disable items" if there are items that are disabling stuff New functionality: - ifStat and ifEnemyStat for PerStat and StatCondition config checks - ifTagType for tag type config checks - if SkillData for skill data config checks - config tab now supports multiple if checks at once - Replaced all ifXList with support for type checking the value so if value is list it will be treated as list of OR checks. This works for all ifX conditions in config tab instead of only specific ones that had list support before - Do not account for "Base" mods (mods from CalcSetup) as actual used conditions as they are used only as descriptors for what the mods do - IfMod can now only account for presence of mod regardless of flags and conditions Signed-off-by: Tomas Slusny <slusnucky@gmail.com>
99f4699
to
e8cedc9
Compare
…athOfBuildingCommunity#5712) Config changes: - Remove "Is your Crit Chance Lucky?" - The only sources can already be enabled with existing conditions and the lucky is implied after that (Blood Sacrament, Focus Mod, Dance with Death) - Only show "# of times skill has chained" if there is condition behind it (Gloomfang for example) - Only show "# of times skill has pierced" if there is condition behind it (Drillneck for example) - Only show "melee distance to enemy" if there is stat that depends on melee proximity (Close Combat, Slayer for example) - Only show "projectile travel distance if there is stat that depends on distance ramp (Point Blank, Longshot for example) - Only show "is enemy bleeding" if there is condition behind it (Bloodletting for example) - Only show "# of poison on enemy" if there is condition behind it (Vile Toxins for example)A - Only show "is the enemy maimed" if there is condition behind it (Maim support for example) - Only show "is enemy burning" if there is condition behind it - Only show "is enemy ignited" if there is condition behind it (Snowforged for example) - Only show "is enemy frozen" if there is condition behind it - Only show "effect of shock" if enemy is shocked - Only show "is enemy on consecrated ground" if there is condition behind it (Bottled Faith for example) - Only show "disable ehp gain on block" if there are any on block effects - Only show "life regen mode" if there is effect that depends on it (Enduring Cry etc) - Only show "armour calculation mode" if there is effect that depends on it (armour mastery etc) - Only show "enemy corpse life" if there is skill that depends on it (Cremation, Detonate Dead) - Only show "# of summoned totems" if there is perstat or enemy mult that depends on it - Only show "is enemy moving" if player has bleedchance - Only show "Don't disable items" if there are items that are disabling stuff New functionality: - ifStat and ifEnemyStat for PerStat and StatCondition config checks - ifTagType for tag type config checks - if SkillData for skill data config checks - config tab now supports multiple if checks at once - Replaced all ifXList with support for type checking the value so if value is list it will be treated as list of OR checks. This works for all ifX conditions in config tab instead of only specific ones that had list support before - Do not account for "Base" mods (mods from CalcSetup) as actual used conditions as they are used only as descriptors for what the mods do - IfMod can now only account for presence of mod regardless of flags and conditions Signed-off-by: Tomas Slusny <slusnucky@gmail.com>
Config changes:
enabled with existing conditions and the lucky is implied after that
(Blood Sacrament, Focus Mod, Dance with Death)
it (Gloomfang for example)
it (Drillneck for example)
melee proximity (Close Combat, Slayer for example)
distance ramp (Point Blank, Longshot for example)
(Bloodletting for example)
Toxins for example)A
support for example)
(Snowforged for example)
behind it (Bottled Faith for example)
effects
(Cremation, Detonate Dead)
that depends on it
New functionality:
conditions as they are used only as descriptors for what the mods do
Link to a build that showcases this PR:
https://pobb.in/8dGpjGCyF-w7
Before screenshot (empty pob):
After screenshot (empty pob):