Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide config options that can be hidden by default behind conditions #5712

Merged

Conversation

deathbeam
Copy link
Contributor

@deathbeam deathbeam commented Feb 25, 2023

Config changes:

  • Remove "Is your Crit Chance Lucky?" - The only sources can already be
    enabled with existing conditions and the lucky is implied after that
    (Blood Sacrament, Focus Mod, Dance with Death)
  • Only show "# of times skill has chained" if there is condition behind
    it (Gloomfang for example)
  • Only show "# of times skill has pierced" if there is condition behind
    it (Drillneck for example)
  • Only show "melee distance to enemy" if there is stat that depends on
    melee proximity (Close Combat, Slayer for example)
  • Only show "projectile travel distance if there is stat that depends on
    distance ramp (Point Blank, Longshot for example)
  • Only show "is enemy bleeding" if there is condition behind it
    (Bloodletting for example)
  • Only show "# of poison on enemy" if there is condition behind it (Vile
    Toxins for example)A
  • Only show "is the enemy maimed" if there is condition behind it (Maim
    support for example)
  • Only show "is enemy burning" if there is condition behind it
  • Only show "is enemy ignited" if there is condition behind it
    (Snowforged for example)
  • Only show "is enemy frozen" if there is condition behind it
  • Only show "effect of shock" if enemy is shocked
  • Only show "is enemy on consecrated ground" if there is condition
    behind it (Bottled Faith for example)
  • Only show "disable ehp gain on block" if there are any on block
    effects
  • Only show "life regen mode" if there is effect that depends on it (Enduring Cry etc)
  • Only show "armour calculation mode" if there is effect that depends on it (armour mastery etc)
  • Only show "enemy corpse life" if there is skill that depends on it
    (Cremation, Detonate Dead)
  • Only show "# of summoned totems" if there is perstat or enemy mult
    that depends on it
  • Only show "is enemy moving" if player has bleedchance
  • Only show "Don't disable items" if there are items that are disabling stuff

New functionality:

  • ifStat and ifEnemyStat for PerStat and StatCondition config checks
  • ifTagType for tag type config checks
  • if SkillData for skill data config checks
  • config tab now supports multiple if checks at once
  • Replaced all ifXList with support for type checking the value so if value is list it will be treated as list of OR checks. This works for all ifX conditions in config tab instead of only specific ones that had list support before
  • Do not account for "Base" mods (mods from CalcSetup) as actual used
    conditions as they are used only as descriptors for what the mods do
  • IfMod can now only account for presence of mod regardless of flags and conditions

Link to a build that showcases this PR:

https://pobb.in/8dGpjGCyF-w7

Before screenshot (empty pob):

image

After screenshot (empty pob):

image

@QuickStick123 QuickStick123 added enhancement New feature, calculation, or mod user-interface Changes that only affect the UI labels Feb 25, 2023
@deathbeam deathbeam force-pushed the more-buff-checks branch 6 times, most recently from 9f186af to a4815f2 Compare February 25, 2023 19:23
@deathbeam
Copy link
Contributor Author

Also added hiding for "disable ehp gain on block" only if there are on block mods present

@deathbeam
Copy link
Contributor Author

Also added support for hiding:

  • life regen mode
  • armour calculation mode

And changed all the ifXList to support type checking the value and treating lists correctly as list of OR checks. This also applies to all ifX options not to just specific ones with ifXList support

@deathbeam
Copy link
Contributor Author

Added also hiding for enemyCorpseLife. This is last of the "relatively easy to hide" config options that I found I think.

@deathbeam deathbeam force-pushed the more-buff-checks branch 3 times, most recently from 3ed7983 to 731a8d6 Compare February 25, 2023 20:53
@Regisle
Copy link
Member

Regisle commented Feb 25, 2023

Also added hiding for "disable ehp gain on block" only if there are on block mods present

that config option also disables on suppress as well, so needs to show if those are in build

@deathbeam
Copy link
Contributor Author

Ah completely missed that, updated (also updated the label and tooltip of the option to also mention suppress while at it)

@Nightblade
Copy link
Contributor

Nightblade commented Feb 27, 2023

Will there be some mechanism to override/show all this?

@deathbeam
Copy link
Contributor Author

Not planning anything like that for this PR at least. But also all of the option this PR is hiding do not do anything when checked anyway except the crit lucky one without them actually enabling anything that is already in the build, so I dont rly see the need either

@Nightblade
Copy link
Contributor

Oh OK, carry on then! 👍

@QuickStick123 QuickStick123 removed the enhancement New feature, calculation, or mod label Feb 27, 2023
@deathbeam deathbeam force-pushed the more-buff-checks branch 3 times, most recently from d2182c5 to 01525d5 Compare March 1, 2023 21:16
@deathbeam deathbeam force-pushed the more-buff-checks branch 4 times, most recently from a4338b1 to 8a29700 Compare March 3, 2023 12:37
@deathbeam
Copy link
Contributor Author

Another additions:

  • Only show "# of summoned totems" if there is perstat or enemy mult
    that depends on it
  • Only show "is enemy moving" if player has bleedchance
  • Do not account for "Base" mods (mods from CalcSetup) as actual used
    conditions as they are used only as descriptors for what the mods do
  • IfMod can now only account for presence of mod regardless of flags and conditions

@deathbeam
Copy link
Contributor Author

Added autohiding for new "Don't disable items" config option, now it only shows if there are items that are disabling anything (from #5664)

Config changes:

- Remove "Is your Crit Chance Lucky?" - The only sources can already be
  enabled with existing conditions and the lucky is implied after that
  (Blood Sacrament, Focus Mod, Dance with Death)
- Only show "# of times skill has chained" if there is condition behind
  it (Gloomfang for example)
- Only show "# of times skill has pierced" if there is condition behind
  it (Drillneck for example)
- Only show "melee distance to enemy" if there is stat that depends on
  melee proximity (Close Combat, Slayer for example)
- Only show "projectile travel distance if there is stat that depends on
  distance ramp (Point Blank, Longshot for example)
- Only show "is enemy bleeding" if there is condition behind it
  (Bloodletting for example)
- Only show "# of poison on enemy" if there is condition behind it (Vile
  Toxins for example)A
- Only show "is the enemy maimed" if there is condition behind it (Maim
  support for example)
- Only show "is enemy burning" if there is condition behind it
- Only show "is enemy ignited" if there is condition behind it
  (Snowforged for example)
- Only show "is enemy frozen" if there is condition behind it
- Only show "effect of shock" if enemy is shocked
- Only show "is enemy on consecrated ground" if there is condition
  behind it (Bottled Faith for example)
- Only show "disable ehp gain on block" if there are any on block
  effects
- Only show "life regen mode" if there is effect that depends on it (Enduring Cry etc)
- Only show "armour calculation mode" if there is effect that depends on it (armour mastery etc)
- Only show "enemy corpse life" if there is skill that depends on it
  (Cremation, Detonate Dead)
- Only show "# of summoned totems" if there is perstat or enemy mult
  that depends on it
- Only show "is enemy moving" if player has bleedchance
- Only show "Don't disable items" if there are items that are disabling
  stuff

New functionality:

- ifStat and ifEnemyStat for PerStat and StatCondition config checks
- ifTagType for tag type config checks
- if SkillData for skill data config checks
- config tab now supports multiple if checks at once
- Replaced all ifXList with support for type checking the value so if value is list it will be treated as list of OR checks. This works for all ifX conditions in config tab instead of only specific ones that had list support before
- Do not account for "Base" mods (mods from CalcSetup) as actual used
  conditions as they are used only as descriptors for what the mods do
- IfMod can now only account for presence of mod regardless of flags and conditions

Signed-off-by: Tomas Slusny <slusnucky@gmail.com>
@LocalIdentity LocalIdentity merged commit 62c0639 into PathOfBuildingCommunity:dev Apr 2, 2023
Dullson pushed a commit to Dullson/PathOfBuilding that referenced this pull request Dec 6, 2023
…athOfBuildingCommunity#5712)

Config changes:

- Remove "Is your Crit Chance Lucky?" - The only sources can already be
  enabled with existing conditions and the lucky is implied after that
  (Blood Sacrament, Focus Mod, Dance with Death)
- Only show "# of times skill has chained" if there is condition behind
  it (Gloomfang for example)
- Only show "# of times skill has pierced" if there is condition behind
  it (Drillneck for example)
- Only show "melee distance to enemy" if there is stat that depends on
  melee proximity (Close Combat, Slayer for example)
- Only show "projectile travel distance if there is stat that depends on
  distance ramp (Point Blank, Longshot for example)
- Only show "is enemy bleeding" if there is condition behind it
  (Bloodletting for example)
- Only show "# of poison on enemy" if there is condition behind it (Vile
  Toxins for example)A
- Only show "is the enemy maimed" if there is condition behind it (Maim
  support for example)
- Only show "is enemy burning" if there is condition behind it
- Only show "is enemy ignited" if there is condition behind it
  (Snowforged for example)
- Only show "is enemy frozen" if there is condition behind it
- Only show "effect of shock" if enemy is shocked
- Only show "is enemy on consecrated ground" if there is condition
  behind it (Bottled Faith for example)
- Only show "disable ehp gain on block" if there are any on block
  effects
- Only show "life regen mode" if there is effect that depends on it (Enduring Cry etc)
- Only show "armour calculation mode" if there is effect that depends on it (armour mastery etc)
- Only show "enemy corpse life" if there is skill that depends on it
  (Cremation, Detonate Dead)
- Only show "# of summoned totems" if there is perstat or enemy mult
  that depends on it
- Only show "is enemy moving" if player has bleedchance
- Only show "Don't disable items" if there are items that are disabling
  stuff

New functionality:

- ifStat and ifEnemyStat for PerStat and StatCondition config checks
- ifTagType for tag type config checks
- if SkillData for skill data config checks
- config tab now supports multiple if checks at once
- Replaced all ifXList with support for type checking the value so if value is list it will be treated as list of OR checks. This works for all ifX conditions in config tab instead of only specific ones that had list support before
- Do not account for "Base" mods (mods from CalcSetup) as actual used
  conditions as they are used only as descriptors for what the mods do
- IfMod can now only account for presence of mod regardless of flags and conditions

Signed-off-by: Tomas Slusny <slusnucky@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
user-interface Changes that only affect the UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants