Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to search Character import list by Ascendancy #7824

Merged

Conversation

justjuangui
Copy link
Contributor

when you use a table in a Dropdown Class you are enabled to use a searchFilter field from your table or use the label.

This enabled to separated Visual things from Search things.

@Paliak Paliak added the user-interface Changes that only affect the UI label Jul 22, 2024
@ryuukk
Copy link
Contributor

ryuukk commented Jul 23, 2024

I think this is a good idea

Could you include the rendering fix from my PR?

#7844

the stuff in the Draw function

@justjuangui
Copy link
Contributor Author

I think this is a good idea

Could you include the rendering fix from my PR?

#7844

the stuff in the Draw function

Done!

@LocalIdentity LocalIdentity changed the title Enhance Dropdown to be able to use searchFilter or Label Add support to search Character import list by Ascendancy Jul 23, 2024
@LocalIdentity LocalIdentity merged commit 412277c into PathOfBuildingCommunity:dev Jul 23, 2024
2 checks passed
@justjuangui justjuangui deleted the enable_search_ascendancy branch July 23, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
user-interface Changes that only affect the UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants