Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take into account the detail value when searching in a DropDown control #7844

Closed
wants to merge 3 commits into from

Conversation

ryuukk
Copy link
Contributor

@ryuukk ryuukk commented Jul 23, 2024

Fixes # .

Description of the problem being solved:

Steps taken to verify a working solution:

  • Import a character
  • Search by typing a class/ascendancy name

Link to a build that showcases this PR:

Before screenshot:

image

After screenshot:

image

I now need to figure out how to render the search result highlighting on the detail field, but that'll require more thoughts, i'll do that on a separate PR

@Paliak Paliak added the user-interface Changes that only affect the UI label Jul 23, 2024
@LocalIdentity
Copy link
Contributor

Superseded by #7824

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
user-interface Changes that only affect the UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants