Adapt the DiffExAnalyzer to handle pre-existing subset structure #1309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When performing a subset DE analysis, check if the subset structure already exists. Adapt DiffExAnalyzer to work with pre-existing subset structure. Make sure that upon deletion, subsets are preserved. This is applicable to single-cell datasets. Add a test case for a subset analysis with a pre-existing subset structure. Make generating R-compatible name more consistent.
arteymix
added
enhancement
Make AnalysisSelectionAndExecutionService package-private and make determineAnalysisType() a static utility method.
Make it so that CLIs can have a MessageSource or access to an Environment when building options or. Fix lazy initialization error when running DE. I've centralized thawing logic in a shared class for the persistence package so that we can have consistent behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When performing a subset DE analysis, check if the subset structure already exists. Adapt DiffExAnalyzer to work with pre-existing subset structure.
Make sure that upon deletion, subsets are preserved.
This is applicable to single-cell datasets.
Add a test case for a subset analysis with a pre-existing subset structure.
Make generating R-compatible name more consistent.