identityCardType as new ALU request parameter #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -119,6 +124,16 @@ public function withIdentityCardSeries($identityCardSeries) | |||
| } | |||
|
|
|||
| /** | |||
| * @param string $identityCardType | |||
| * @return $this | |||
There was a problem hiding this comment.
I guess the return should be Billing here
There was a problem hiding this comment.
i followed the existing code pattern. The return is the self billing object
There was a problem hiding this comment.
Indeed. The existing pattern is bad everywhere. How it is right now works in PHPStorm for autocomplete but other developers might not be that lucky.
I guess it would be better to have a separate task for changing it.
Let's leave it like this for this current pull request.
|
Please make sure the tests are passing. |
added 2 commits
February 19, 2016 17:55
|
I don't think there is any reason to have the commit 886eefb. Can we revert it? |
added 2 commits
February 22, 2016 11:26
This reverts commit 75ea199.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.