buys and sell on exchange #1184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
asaadam
reviewed
Jul 10, 2023
| @@ -632,9 +633,47 @@ export const SommelierTab: VFC<DepositModalProps> = ({ | |||
| > | |||
| https://wrapeth.com/ | |||
| </Link> | |||
| <br /> | |||
| <br /> | |||
There was a problem hiding this comment.
somehow I do prefer we're not using double <br/>, instead you can using marginTop css
There was a problem hiding this comment.
@asaadam can we go live with current version and meanwhile Ill try to test how to get marginTop properly working
asaadam
reviewed
Jul 10, 2023
| base assets. Please swap outside our app for | ||
| better rates. | ||
| </Text> | ||
| <br /> |
asaadam
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ##1173
Rhino links to "Real Yield ETH" and "Real Yield USD" deposit modals
#1173
"Real Yield ETH" link: https://app.rhino.fi/invest/YIELDETH/supply
"Real Yield USD" link:https://app.rhino.fi/invest/YIELDUSD/supply
Changes
List any technical changes.
Screenshots (if appropriate):
Testing Steps
As a reviewer, what steps should I take to verify this is working correctly?
Links
Add links to Figma files, documentation, etc.