Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buys and sell on exchange #1184

Merged
merged 1 commit into from
Jul 12, 2023
Merged

buys and sell on exchange #1184

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 40 additions & 1 deletion src/components/_modals/DepositModal/SommelierTab.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ import { CellarNameKey } from "data/types"
import { useStrategyData } from "data/hooks/useStrategyData"
import { useUserStrategyData } from "data/hooks/useUserStrategyData"
import { useDepositModalStore } from "data/hooks/useDepositModalStore"
import { FaExternalLinkAlt } from "react-icons/fa"

interface DepositModalProps
extends Pick<ModalProps, "isOpen" | "onClose"> {
Expand Down Expand Up @@ -632,9 +633,47 @@ export const SommelierTab: VFC<DepositModalProps> = ({
>
https://wrapeth.com/
</Link>
<br />
<br />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

somehow I do prefer we're not using double <br/>, instead you can using marginTop css

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asaadam can we go live with current version and meanwhile Ill try to test how to get marginTop properly working

<Link
href={
"https://app.rhino.fi/invest/YIELDETH/supply"
}
isExternal
role="group"
textAlign="center"
>
<Text as="span">Buy and sell on exchange </Text>
<Icon
as={FaExternalLinkAlt}
color="purple.base"
/>
</Link>
</>
) : (
" There could be high slippage when depositing non base assets. Please swap outside our app for better rates."
<>
<Text>
There could be high slippage when depositing non
base assets. Please swap outside our app for
better rates.
</Text>
<br />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same thing here

<br />
<Link
href={
"https://app.rhino.fi/invest/YIELDUSD/supply"
}
isExternal
role="group"
textAlign="center"
>
<Text as="span">Buy and sell on exchange </Text>
<Icon
as={FaExternalLinkAlt}
color="purple.base"
/>
</Link>
</>
)}
</Text>
)}
Expand Down