Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support chinese and could change markdown engine #134

Closed
xubin0523 opened this issue Oct 8, 2014 · 7 comments
Closed

support chinese and could change markdown engine #134

xubin0523 opened this issue Oct 8, 2014 · 7 comments
Labels
Milestone

Comments

@xubin0523
Copy link

Can you make elegent more friendly to chinese language and could changing markdown engine (I don't like python style)? It looks not perfect to my blog[http://xubin0523.github.io/bits.html]

@xubin0523
Copy link
Author

I use this Font which works fine in chinese.

font-family: Times, "Hiragino Sans GB", "Microsoft YaHei",
                 "WenQuanYi Micro Hei", sans-serif;

@silverhook
Copy link
Member

@xubin0523, does this still happen with latest version?

@calfzhou, can you help here?

@talha131
Copy link
Member

We can't change Markdown engine. Pelican handles Markdown for us.

If typography is the only issue then we can solve it by adding an article in the documentation.

@silverhook
Copy link
Member

If it only means to add a font that should not be too hard to do.

@talha131 talha131 added this to the Roadmap milestone Jun 17, 2019
@talha131
Copy link
Member

I can think of two ways to solve this issue

Using CSS

Tell CSS to use specific fonts for a language. For example special fonts for Chinese or Urdu

But does it mean we will have to ship theme with fonts? How will it affect the size of page that does not use a font?

Provide CSS configuration

We already have custom CSS. But can we have a file like pelicanconf but for Eelegant CSS.

This file will resize in the root of the blog source code. It will have variables like BODY_FONT and then elegant will pick up this variable and use it in its CSS files.

I am not sure if it is even possible.

Existing solution

  1. Use custom.css
  2. Add article in docs to tell user to use so and so fonts for so and so languages
    (Can user embed his own fonts easily?)

@talha131
Copy link
Member

talha131 commented Jul 5, 2019

2711aa0

@talha131 talha131 closed this as completed Jul 5, 2019
talha131 pushed a commit that referenced this issue Jul 14, 2019
# [3.1.0](V3.0.0...V3.1.0) (2019-07-14)

### Bug Fixes

* **article:** fix regression introduced in 7ca7331 ([2c23961](2c23961))
* **authors:** title attribute was not closed in quotes ([de1d05b](de1d05b))
* **gist:** embedded Github gist are not laid out correctly ([0416433](0416433)), closes [#123](#123)
* **reST:** indents in line blocks is not preserved ([e1429c5](e1429c5)), closes [#144](#144)

### Features

* **article:** make article subtitle italic ([7ca7331](7ca7331)), closes [#284](#284)
* **authors:** add line above authors section ([35a35b0](35a35b0))
* **authors:** add support for avatar ([cc92230](cc92230)), closes [#362](#362)
* **authors:** make authors URL nofollow ([07bf415](07bf415))
* **authors:** move authors below share links section ([b81555a](b81555a))
* **authors:** open author url in a new window ([f97b47a](f97b47a))
* **Chinese:** add better font support for Chinese language ([2711aa0](2711aa0)), closes [#134](#134)
* **modified:** show Last Updated only if the difference between created and modified is more than a day ([b0eac79](b0eac79))
* **monetization:** add BestAzon support ([6d8a23c](6d8a23c))
@talha131
Copy link
Member

🎉 This issue has been resolved in version 3.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

3 participants