Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gravatar hovercards ? #362

Closed
iranzo opened this issue Jun 19, 2019 · 14 comments
Closed

Gravatar hovercards ? #362

iranzo opened this issue Jun 19, 2019 · 14 comments

Comments

@iranzo
Copy link
Member

iranzo commented Jun 19, 2019

I found http://en.gravatar.com/support/profile-hovercards/ while checking for something else, something we want to add?

@talha131
Copy link
Member

Our author field is much better than this. Don't you think? See #185

Pelican even has option of creating author pages.

What we can do is to fetch avatar from gravatar and show it beside author. We will probably have to make a plugin first.

@iranzo
Copy link
Member Author

iranzo commented Jun 19, 2019

If we want to fetch from gravatar it's really easy (https://es.gravatar.com/site/implement/images/ ):

Seems that https://github.com/getpelican/pelican-plugins/tree/master/gravatar does that for us providing that data to the templates

@talha131 talha131 added this to the Roadmap milestone Jun 19, 2019
@talha131
Copy link
Member

Good find. I have added it to the roadmap.

@silverhook
Copy link
Member

How about https://www.libravatar.org/?

@talha131
Copy link
Member

talha131 commented Jul 5, 2019

We can't use gravatar plugin. It won't work with our authors field.

What we can do here is

  • add a avatar field to the AUTHORS dictionary
  • if it is defined then we show it along with the blurb

This way user can himself decide whether he wants to use gravatar, imgur or libravatar.

@talha131 talha131 modified the milestones: Roadmap, 2019 - Q3 Jul 5, 2019
@iranzo
Copy link
Member Author

iranzo commented Jul 5, 2019

Sounds good

talha131 added a commit that referenced this issue Jul 5, 2019
@talha131
Copy link
Member

talha131 commented Jul 5, 2019

cc92230

@talha131 talha131 closed this as completed Jul 5, 2019
@talha131
Copy link
Member

talha131 commented Jul 5, 2019

Guys let me know (esp. @iranzo @azzamsa) what do you think of this dict keys

    "Talha Mansoor": {
        "url": "https://www.oncrashreboot.com/",
        "blurb": "is the creator and lead developer of Elegant theme.",
        "avatar": "/images/avatars/talha131.png",
    },

specifically do you think avatar key should be replaced with something better?

I will hold on the release for few days until I hear back from you.

@iranzo
Copy link
Member Author

iranzo commented Jul 5, 2019

Can we provide 'avatar' as 'url' ? In that case we can use gravatar or whatever we want, we can either go to gravatar and copy url from there and one file less to add to repo as static one

for example, in my case: https://es.gravatar.com/userimage/47837087/6e8d2c6bc801fb6ea9cdad090b4f5814.jpg?size=200

BTW, what about the size for the image? any limitation or does the template fixes it? (Seems 32x32 right? )

thanks

@talha131
Copy link
Member

talha131 commented Jul 5, 2019

Yes, you can give any url, gravatar or imgur or whatever.

I have fixed size to 32x32. Least distractive.

@iranzo
Copy link
Member Author

iranzo commented Jul 5, 2019

+1 from me to merge then :)

@azzamsa
Copy link
Contributor

azzamsa commented Jul 5, 2019

Looks good to me. Github use the same thing except it has gravatar_id

"avatar_url": "https://github.com/images/error/octocat_happy.gif",
"gravatar_id": "",

@talha131
Copy link
Member

talha131 commented Jul 5, 2019

Cool. Then we are going to stay with avatar key.

talha131 pushed a commit that referenced this issue Jul 14, 2019
# [3.1.0](V3.0.0...V3.1.0) (2019-07-14)

### Bug Fixes

* **article:** fix regression introduced in 7ca7331 ([2c23961](2c23961))
* **authors:** title attribute was not closed in quotes ([de1d05b](de1d05b))
* **gist:** embedded Github gist are not laid out correctly ([0416433](0416433)), closes [#123](#123)
* **reST:** indents in line blocks is not preserved ([e1429c5](e1429c5)), closes [#144](#144)

### Features

* **article:** make article subtitle italic ([7ca7331](7ca7331)), closes [#284](#284)
* **authors:** add line above authors section ([35a35b0](35a35b0))
* **authors:** add support for avatar ([cc92230](cc92230)), closes [#362](#362)
* **authors:** make authors URL nofollow ([07bf415](07bf415))
* **authors:** move authors below share links section ([b81555a](b81555a))
* **authors:** open author url in a new window ([f97b47a](f97b47a))
* **Chinese:** add better font support for Chinese language ([2711aa0](2711aa0)), closes [#134](#134)
* **modified:** show Last Updated only if the difference between created and modified is more than a day ([b0eac79](b0eac79))
* **monetization:** add BestAzon support ([6d8a23c](6d8a23c))
@talha131
Copy link
Member

🎉 This issue has been resolved in version 3.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants