Director cli hookup #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has director code which compiles but does not populate the origin/cache information nor does it do GeoIP yet.
PR #7 introduced a framework for including the Director in the Pelican CLI, toward making all Pelican services available under a single binary. This commit extends that PR to hook the Director package up to the CLI, the Pelican's configuration mechanisms, and to actually sort out a few bugs related to the untested director code. It should be noted that there are currently a few hacks in the code that need clearing up before any merge, but as of now the commit makes the following possible: `pelican director serve --cache-port 8000` This will serve the Director's cache-redirection service on port 8000 using a gin engine. When we've figured out how to handle Origin redirects and implemented an origin-redirect service, we'll be able to do: `pelican director serve --cache-port 8000 --origin-port 8001` to split apart the two endpoints. As for the local lint... I'm still trying to figure out how to shut that feature off in my editor. Sorry for the noise!
The Director must be able to redirect to origins, so we modified topology such that the needed information can be fed into the Director. Now the `/api/v1.0/director/object` and `/api/v1.0/director/origin` endpoints direct to caches and origins, respectively. There are also a few smaller bug fixes in here, like fixing the ttlcache timing out and having no reload mechanism.
|
@jhiemstrawisc - there's still the merge conflict left to resolve. What else remains on the punch list? |
|
AFAIK, it should just be the merge conflict. I left that for myself to do this morning. I'm still waiting for the updates in topology (pretty sure that PR just needs a rebase and merge), but I was able to test with the new draft JSON that has the correct ports -- and ospool origin. Once I get this merged, I'll start working on a deployment. |
|
@bbockelm I think this is ready |
bbockelm
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #7 introduced a framework for including the Director in the Pelican CLI, toward making all Pelican services available under a single binary. This commit extends that PR to hook the Director package up to the CLI, the Pelican's configuration mechanisms, and to actually sort out a few bugs related to the untested director code.
It should be noted that there are currently a few hacks in the code that need clearing up before any merge, but as of now the commit makes the following possible:
pelican director serve --cache-port 8000This will serve the Director's cache-redirection service on port 8000 using a gin engine. When we've figured out how to handle Origin redirects and implemented an origin-redirect service, we'll be able to do:
pelican director serve --cache-port 8000 --origin-port 8001to split apart the two endpoints.
As for the local lint... I'm still trying to figure out how to shut that feature off in my editor. Sorry for the noise!