Add Director capability into the Pelican CLI #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has director code which compiles but does not populate the origin/cache information nor does it do GeoIP yet.
jhiemstrawisc
referenced
this pull request
in jhiemstrawisc/pelican
Jul 21, 2023
PR #7 introduced a framework for including the Director in the Pelican CLI, toward making all Pelican services available under a single binary. This commit extends that PR to hook the Director package up to the CLI, the Pelican's configuration mechanisms, and to actually sort out a few bugs related to the untested director code. It should be noted that there are currently a few hacks in the code that need clearing up before any merge, but as of now the commit makes the following possible: `pelican director serve --cache-port 8000` This will serve the Director's cache-redirection service on port 8000 using a gin engine. When we've figured out how to handle Origin redirects and implemented an origin-redirect service, we'll be able to do: `pelican director serve --cache-port 8000 --origin-port 8001` to split apart the two endpoints. As for the local lint... I'm still trying to figure out how to shut that feature off in my editor. Sorry for the noise!
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first draft of the conversion of the Director code into the Pelican CLI.
While it compiles, it's not tested -- just a rote conversion of the existing Python code. It does include GeoIP lookup and integration with topology. Currently, the biggest missing piece (beyond testing/debugging) is actually hooking it into the CLI itself.