Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update S3 plugin in containers to fix segfault #1207

Merged
merged 1 commit into from
May 1, 2024

Conversation

jhiemstrawisc
Copy link
Member

@jhiemstrawisc jhiemstrawisc commented May 1, 2024

The v0.1.1 plugin had a snippet of code that wasn't thread safe, but was only triggered in the case of PUTs. That has been fixed/tagged upstream in this issue.

This PR updates the plugin version used in our containers.

@haoming29, when this is merged we should also patch it into 7.7

@jhiemstrawisc jhiemstrawisc requested a review from turetske May 1, 2024 20:30
@jhiemstrawisc jhiemstrawisc added bug Something isn't working critical High priority for next release labels May 1, 2024
@jhiemstrawisc jhiemstrawisc added this to the v7.8.0 milestone May 1, 2024
@haoming29
Copy link
Contributor

@jhiemstrawisc For the patch to 7.7, how do we want to do it? There's no source code change and it will only affect containers. Do we want to only release a container build with a release note (but without the actual git tag)?

@jhiemstrawisc
Copy link
Member Author

I think your approach is reasonable. Can we rebuild containers based on this PR for the previous v7.7.X releases without creating a new tag?

@jhiemstrawisc jhiemstrawisc merged commit 675c5e5 into PelicanPlatform:main May 1, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working critical High priority for next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants