Switch static variable to thread_local to fix underflow bug #33
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple threads appear to be running through
read_callback
with their own data, and they're fighting over thesentSoFar
variable. Switching it from static to thread_local makes sure each thread has its own copy to use.I understand less about how XRootD manages threads, but making this switch appears to fix what was otherwise a guaranteed crash.
Closes #32