Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Token on project level notification is lost after restart of TeamCity #86

Closed
LeoHexspoor opened this issue May 10, 2016 · 0 comments

Comments

@LeoHexspoor
Copy link

API Token's configured on project level notifications are lost after TeamCity is restart.

Repro steps:

  1. Create a project level notification with an API Token
  2. Restart TeamCity
  3. View previously created notification, the API token is lost

Looking in the generated settings XML you can see that the API token is not stored as part of the XML. I believe the problem is in the SlackNotificationConfig class in the core project. When SlackNotificationConfig is instantiated with an Element it tries to read the "token" attribute, but the token attribute is never added in the getAsElement method.

marvin-w added a commit that referenced this issue Aug 19, 2016
Set API token in SlackNotificationConfig#getAsElement, fixes #86
marvin-w added a commit that referenced this issue Aug 19, 2016
Revert "Set API token in SlackNotificationConfig#getAsElement, fixes #86"
marvin-w added a commit that referenced this issue Aug 19, 2016
Set API token in SlackNotificationConfig#getAsElement, fixes #86
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant