Set API token in SlackNotificationConfig#getAsElement, fixes #86

[tonybaroneee]

For backwards-compatibility, allows configs to be read/written without a token set. Includes test updates as well.

This reverts commit 4b8cb62.

[tonybaroneee]

@pointerxr Ok, here's the updated PR with fixed tests and a slightly more robust implementation (makes sure token is not null before attempting to setAttribute).

[marvin-w]

Thanks +1 for the fast resolve

[tonybaroneee]

Thank you for the quick merge! Any idea on a timeframe for a release?

[marvin-w]

Unfortunately I don't have permissions to release a new version. Furthermore it seems that Pete, the owner, is no longer participating here.

Also as I planned the refactor almost the complete codebase I do believe that I fork this project in the future and maintain it myself if Pete doesn't reply anymore.

[tonybaroneee]

Ah, understood. Thanks for the heads up.

[marvin-w]

I got some time today so I might set it up accordingly after I tried to reach Pete again to give me appropriate permissions or release it.

[marvin-w]

https://github.com/PeteGoo/tcSlackBuildNotifier/releases/tag/v1.4.6

have fun!

[tonybaroneee]

Thank you so much!!

[marvin-w]

You're welcome. Can you tell me which issues are currently most requested? I got some time left to do some of them.

[tonybaroneee]

No clue :) This was the only issue that was burning us after server restarts, so glad we could get a fix in so quickly.