Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Google Analytics and correct mistyped var #244

Merged
merged 1 commit into from
Aug 1, 2022
Merged

Update Google Analytics and correct mistyped var #244

merged 1 commit into from
Aug 1, 2022

Conversation

litusgm
Copy link
Contributor

@litusgm litusgm commented Jul 27, 2022

Updated old Google Analytics (analytics.js) to new Global site tag (gtag.js) Google Analytics.

BTW old Google Analytics was not working here because of mistyped variable.

@litusgm
Update Google Analytics and correct mistyped var
949c61d 
Updated old Google Analytics (analytics.js) to new Global site tag (gtag.js) Google Analytics.

BTW old Google Analytics was not working here because of mistyped variable.
@TWiStErRob
Copy link
Contributor

Where's the mistyped var?

@litusgm
Copy link
Contributor Author

litusgm commented Jul 30, 2022

Where's the mistyped var?

Line 95 of _includes/_head.html file says:
ga('create', '{{ site.analytics.google.tracking_id }}', 'auto');
where the variable name should be site.google_analytics_tracking_id.

At least for me it wasn't working until I changed this bit of code.

After that I changed the code to use the new gtag.js by Google.

@TWiStErRob
Copy link
Contributor

TWiStErRob commented Jul 30, 2022 •
edited
Loading

Ah, nice catch, looks like it was copy pasted from the suggestion in #142 about a year ago and didn't sync up with the structure in this config.

@Phlow Phlow merged commit 3a7ab3d into Phlow:gh-pages Aug 1, 2022
@Phlow
Copy link
Owner

Phlow commented Aug 1, 2022

Hey @litusgm – Thank you very much!

oscoDOTblog added a commit to oscoDOTblog/atemosta-site-v1 that referenced this pull request Mar 5, 2023
@oscoDOTblog @dependabot
@markcmiller86 @Phlow @inetbiz @litusgm @michiexile
Fix Mobile Rendering (#29)
d945fa8 
* Bump kramdown from 2.1.0 to 2.3.0 (Phlow#211)

Bumps [kramdown](https://github.com/gettalong/kramdown) from 2.1.0 to 2.3.0.
- [Release notes](https://github.com/gettalong/kramdown/releases)
- [Changelog](https://github.com/gettalong/kramdown/blob/master/doc/news.page)
- [Commits](https://github.com/gettalong/kramdown/commits)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update _06_typography.scss (Phlow#221)

* Revert Commit which destroyed the mobile navigation

* Update 2015-08-16-typography.md

Fixed an URL

* Added jekyll-theme-feeling-responsive.gemspec

* New Analytics › Moved from Footer to Head to increase speed › Use GA Async Tag

See › Phlow#142

* Update images, some text, some formatting

* No mesh together › Nav buttons at bottom of blog posts mesh together

* Bump rexml from 3.2.4 to 3.2.5 (Phlow#227)

Bumps [rexml](https://github.com/ruby/rexml) from 3.2.4 to 3.2.5.
- [Release notes](https://github.com/ruby/rexml/releases)
- [Changelog](https://github.com/ruby/rexml/blob/master/NEWS.md)
- [Commits](ruby/rexml@v3.2.4...v3.2.5)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump kramdown from 2.3.0 to 2.3.1 (Phlow#225)

Bumps [kramdown](https://github.com/gettalong/kramdown) from 2.3.0 to 2.3.1.
- [Release notes](https://github.com/gettalong/kramdown/releases)
- [Changelog](https://github.com/gettalong/kramdown/blob/master/doc/news.page)
- [Commits](https://github.com/gettalong/kramdown/commits)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump addressable from 2.7.0 to 2.8.0 (Phlow#229)

Bumps [addressable](https://github.com/sporkmonger/addressable) from 2.7.0 to 2.8.0.
- [Release notes](https://github.com/sporkmonger/addressable/releases)
- [Changelog](https://github.com/sporkmonger/addressable/blob/main/CHANGELOG.md)
- [Commits](sporkmonger/addressable@addressable-2.7.0...addressable-2.8.0)

---
updated-dependencies:
- dependency-name: addressable
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Broken link

* _11_syntax-highlighting.scss include data-language (Phlow#236)

Adds data-language label in top-right corner of highlight.

* Switched/Flipped Links for mobile order

* Hide the title and icon when full navigation is shown

* Update Google Analytics and correct mistyped var (Phlow#244)

Updated old Google Analytics (analytics.js) to new Global site tag (gtag.js) Google Analytics.

BTW old Google Analytics was not working here because of mistyped variable.

* Handling external links gracefully (Phlow#245)

You are setting `_baseurl` but then using `site.baseurl`.

* Typo

* fix mobile bug

---------

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Mark C. Miller <miller86@llnl.gov>
Co-authored-by: Phlow <mo.phlow@gmail.com>
Co-authored-by: Denver Prophit Jr <denver.prophit@gmail.com>
Co-authored-by: litusgm <109998342+litusgm@users.noreply.github.com>
Co-authored-by: Mikael Vejdemo-Johansson <mikael@johanssons.org>
Co-authored-by: Ousikai <mtfallsVR@protonmail.com>
stefaanh added a commit to stefaanh/feeling-responsive that referenced this pull request Mar 4, 2024
@stefaanh
Merge branch 'gh-pages' of https://github.com/Phlow/feeling-responsive …
690f9dd 
…into gh-pages

* 'gh-pages' of https://github.com/Phlow/feeling-responsive: (23 commits)
  Update Gemfile.lock
  Update changelog.md
  Migrated _sass code to fix deprecation warnings. (Phlow#262)
  Corrected mistake
  Update
  Update documentation.md (Phlow#256)
  Typo
  Handling external links gracefully (Phlow#245)
  Update Google Analytics and correct mistyped var (Phlow#244)
  Hide the title and icon when full navigation is shown
  Switched/Flipped Links for mobile order
  _11_syntax-highlighting.scss include data-language (Phlow#236)
  Broken link
  Bump addressable from 2.7.0 to 2.8.0 (Phlow#229)
  Bump kramdown from 2.3.0 to 2.3.1 (Phlow#225)
  Bump rexml from 3.2.4 to 3.2.5 (Phlow#227)
  No mesh together › Nav buttons at bottom of blog posts mesh together
  Update images, some text, some formatting
  New Analytics › Moved from Footer to Head to increase speed › Use GA Async Tag
  Added jekyll-theme-feeling-responsive.gemspec
  ...

# Conflicts:
#	Gemfile.lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@litusgm @TWiStErRob @Phlow