Handling external links gracefully #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You are setting `_baseurl` but then using `site.baseurl`.
|
Nice one! |
|
@michiexile Sorry for my late response. I don't understand Is it a new command in Jekyll? What does it do? |
|
It's a local variable defined a few lines above that takes URL prefix into account. |
|
@TWiStErRob @michiexile Now I get it ;) – Took a while. |
oscoDOTblog
added a commit
to oscoDOTblog/atemosta-site-v1
that referenced
this pull request
Mar 5, 2023
* Bump kramdown from 2.1.0 to 2.3.0 (Phlow#211) Bumps [kramdown](https://github.com/gettalong/kramdown) from 2.1.0 to 2.3.0. - [Release notes](https://github.com/gettalong/kramdown/releases) - [Changelog](https://github.com/gettalong/kramdown/blob/master/doc/news.page) - [Commits](https://github.com/gettalong/kramdown/commits) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update _06_typography.scss (Phlow#221) * Revert Commit which destroyed the mobile navigation * Update 2015-08-16-typography.md Fixed an URL * Added jekyll-theme-feeling-responsive.gemspec * New Analytics › Moved from Footer to Head to increase speed › Use GA Async Tag See › Phlow#142 * Update images, some text, some formatting * No mesh together › Nav buttons at bottom of blog posts mesh together * Bump rexml from 3.2.4 to 3.2.5 (Phlow#227) Bumps [rexml](https://github.com/ruby/rexml) from 3.2.4 to 3.2.5. - [Release notes](https://github.com/ruby/rexml/releases) - [Changelog](https://github.com/ruby/rexml/blob/master/NEWS.md) - [Commits](ruby/rexml@v3.2.4...v3.2.5) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump kramdown from 2.3.0 to 2.3.1 (Phlow#225) Bumps [kramdown](https://github.com/gettalong/kramdown) from 2.3.0 to 2.3.1. - [Release notes](https://github.com/gettalong/kramdown/releases) - [Changelog](https://github.com/gettalong/kramdown/blob/master/doc/news.page) - [Commits](https://github.com/gettalong/kramdown/commits) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump addressable from 2.7.0 to 2.8.0 (Phlow#229) Bumps [addressable](https://github.com/sporkmonger/addressable) from 2.7.0 to 2.8.0. - [Release notes](https://github.com/sporkmonger/addressable/releases) - [Changelog](https://github.com/sporkmonger/addressable/blob/main/CHANGELOG.md) - [Commits](sporkmonger/addressable@addressable-2.7.0...addressable-2.8.0) --- updated-dependencies: - dependency-name: addressable dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Broken link * _11_syntax-highlighting.scss include data-language (Phlow#236) Adds data-language label in top-right corner of highlight. * Switched/Flipped Links for mobile order * Hide the title and icon when full navigation is shown * Update Google Analytics and correct mistyped var (Phlow#244) Updated old Google Analytics (analytics.js) to new Global site tag (gtag.js) Google Analytics. BTW old Google Analytics was not working here because of mistyped variable. * Handling external links gracefully (Phlow#245) You are setting `_baseurl` but then using `site.baseurl`. * Typo * fix mobile bug --------- Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Mark C. Miller <miller86@llnl.gov> Co-authored-by: Phlow <mo.phlow@gmail.com> Co-authored-by: Denver Prophit Jr <denver.prophit@gmail.com> Co-authored-by: litusgm <109998342+litusgm@users.noreply.github.com> Co-authored-by: Mikael Vejdemo-Johansson <mikael@johanssons.org> Co-authored-by: Ousikai <mtfallsVR@protonmail.com>
stefaanh
added a commit
to stefaanh/feeling-responsive
that referenced
this pull request
Mar 4, 2024
…into gh-pages * 'gh-pages' of https://github.com/Phlow/feeling-responsive: (23 commits) Update Gemfile.lock Update changelog.md Migrated _sass code to fix deprecation warnings. (Phlow#262) Corrected mistake Update Update documentation.md (Phlow#256) Typo Handling external links gracefully (Phlow#245) Update Google Analytics and correct mistyped var (Phlow#244) Hide the title and icon when full navigation is shown Switched/Flipped Links for mobile order _11_syntax-highlighting.scss include data-language (Phlow#236) Broken link Bump addressable from 2.7.0 to 2.8.0 (Phlow#229) Bump kramdown from 2.3.0 to 2.3.1 (Phlow#225) Bump rexml from 3.2.4 to 3.2.5 (Phlow#227) No mesh together › Nav buttons at bottom of blog posts mesh together Update images, some text, some formatting New Analytics › Moved from Footer to Head to increase speed › Use GA Async Tag Added jekyll-theme-feeling-responsive.gemspec ... # Conflicts: # Gemfile.lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You are setting
_baseurlbut then usingsite.baseurl.