Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples Clean-Up #1408

Merged
merged 40 commits into from
Sep 15, 2024
Merged

Examples Clean-Up #1408

merged 40 commits into from
Sep 15, 2024

Conversation

gerth2
Copy link
Contributor

@gerth2 gerth2 commented Sep 5, 2024

Goals:

  • Swerve-first
  • Simulation-first
  • AprilTag-first

Minimize content to achieve those goals.

@gerth2 gerth2 marked this pull request as ready for review September 8, 2024 02:34
@gerth2 gerth2 requested a review from a team as a code owner September 8, 2024 02:34
@gerth2 gerth2 mentioned this pull request Sep 8, 2024
@gerth2 gerth2 linked an issue Sep 8, 2024 that may be closed by this pull request
Copy link
Contributor

@mcm001 mcm001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I leave a review, I say "LGTM" because the code does "look good to me." Very demure, very mindful.

@mdurrani808
Copy link
Contributor

Before merge, I want to take a read through here haha. Will get done Monday or Tuesday this week.

docs/source/docs/apriltag-pipelines/multitag.md Outdated Show resolved Hide resolved
docs/source/docs/examples/aimandrange.md Show resolved Hide resolved
docs/source/docs/examples/poseest.md Outdated Show resolved Hide resolved
docs/source/docs/examples/poseest.md Show resolved Hide resolved
Copy link
Contributor

@mdurrani808 mdurrani808 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

appreciate all the hard work on this, much needed

docs/source/docs/integration/simpleStrategies.md Outdated Show resolved Hide resolved
docs/source/docs/integration/simpleStrategies.md Outdated Show resolved Hide resolved
docs/source/docs/examples/aimingatatarget.md Outdated Show resolved Hide resolved
docs/source/docs/examples/aimingatatarget.md Outdated Show resolved Hide resolved
docs/source/docs/examples/aimingatatarget.md Show resolved Hide resolved
docs/source/docs/examples/aimingatatarget.md Show resolved Hide resolved
docs/source/docs/examples/poseest.md Show resolved Hide resolved
docs/source/docs/apriltag-pipelines/multitag.md Outdated Show resolved Hide resolved
docs/source/docs/integration/advancedStrategies.md Outdated Show resolved Hide resolved
@gerth2
Copy link
Contributor Author

gerth2 commented Sep 13, 2024

#1418 needs to happen shortly after this is merged.

@mcm001
Copy link
Contributor

mcm001 commented Sep 14, 2024

Updates address all my comments, ty!

@mcm001 mcm001 self-requested a review September 14, 2024 20:09
@mcm001 mcm001 merged commit 9e6a066 into PhotonVision:master Sep 15, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Example Rewrites
3 participants