Pr update welding demo #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In commit 397fc070ea87594c0fc9a01b1196dd65b3064a4d of the moveit_task_constructor repo, the `fillMessage` method of the SolutionBase class was renamed to `appendTo`. This commit applies that renaming to the demo code.
Update `ur_robot` macro params Remove "robot_platform_joint" as the updated `ur_robot` macro takes care of connecting the robot to the provided parent link now. Use `xacro.load_yaml` instead of deprecated `load_yaml` function NOTE: these changes are required if the demo is run with an updated version of the ur_description package that provides the `ur_robot` macro
Also add to dependencies in package.xml
spawner.py -> spawner
Otherwise these topics by default are set to "<undefined>" which causes an error when the local planner node attempts to subscribe to them as topic names are not allowed to have the '<' or '>' character in them.
The old ur_controllers/ForceTorqueStateBroadcaster controller does not exist anymore. The updated one to use is from the force_torque_sensor_broadcaster package
dyackzan
force-pushed
the
pr-update-welding-demo
branch
from
668207f to
a441a7c
Compare
Update pre-commit config and fix formatting/spelling throughout repo Update github formatting workflow
dyackzan
force-pushed
the
pr-update-welding-demo
branch
from
a441a7c to
e9e1095
Compare
|
CI is failing here because the warehouse_ros_mongo package has a dependency on the mongodb package, which is not available in Ubuntu Jammy Discussion: moveit/warehouse_ros_mongo#75 (comment) |
The warehouse_ros_mongo package cannot be used on Ubuntu Jammy. It depends on mongodb which has no released version on Jammy. So comment out all portions of the welding demo that reference it.
Remove extra spaces in yaml files to get CI passing
Sending the TF buffer argument in the constructor of a PlanningSceneMonitor object is deprecated.
dyackzan
force-pushed
the
pr-update-welding-demo
branch
2 times, most recently
from
e14f01e to
73ae09e
Compare
dyackzan
force-pushed
the
pr-update-welding-demo
branch
from
73ae09e to
0ec3463
Compare
sjahr
approved these changes
Jan 4, 2024
upstream.repos
Outdated
| @@ -14,8 +14,8 @@ repositories: | |||
| version: ros2 | |||
| ur_msgs: | |||
| type: git | |||
| url: https://github.com/destogl/ur_msgs.git | |||
| version: ros2 | |||
| url: https://github.com/ros-industrial/ur_msgs.git | |||
There was a problem hiding this comment.
Works for me although I think we can remove a bunch of these dependencies. I only needed to build from source:
moveit_task_constructor (humble)
moveit_visual_tools
rosparam_shortcuts
rviz_visual_tools
Maybe consider removing the rest to greatly simplify the whole install setup
moveit_servo is used in the ServoSolver c++ code so it is needed as a build time dependency as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get the welding demo working with the latest humble branches of the moveit repos