fix(CMakeLists.txt): add fPIC compile option #8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @facontidavide , thanks for your great tool!
I recently tried out this tool an it works well!
As I was compiling it with the Autoware, I had some linker errors, you can see my struggle in https://www.twitch.tv/videos/1992007721?t=04h42m28s
In the end, for some reason, when I added
-fPIC
flag to thedata_tamer
package, the linker error was resolved.I am not very good at cmake configuration and overall compiler flags. So I don't have the full understanding of the situation.
In the nebula driver, we use
ament_auto_find_build_dependencies()
andament_auto_add_library()
functions.In my small test, I've simply added
<depend>data_tamer</depend>
to thepackage.xml
so, this might help reproducing on a smaller scale too.Edit: Just to be clear, it compiles, links and functions well with this change applied.