-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upstream: ros2_control deprecation replace fake with mock #32
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think all the URI switches from file://
to package://
are because my original branch was based on a separate moveit_studio
branch we have set up.
If you wanna grab these changes, try rebasing on main and dropping the first 2 commits. Sorry.
I also am not sure if this should go into Humble because the parameter changes will break end users' workflows, all for a deprecation warning. If we are cutting a rolling release, I'd be OK with it there though.
@moriarty branch is rebased on main and contains just the changes we care about. Again, if we can possibly cut a |
Codecov Report
@@ Coverage Diff @@
## main #32 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 5 5
Lines 352 352
=====================================
Misses 352 352
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@sea-bass yeh that makes sense, I'll first do a 0.0.1 release without this change and then merge this after and create a humble branch. |
This fixes the depreciation warning introduced upstream:
ros-controls/ros2_control@9d5d524