Improve Tree deletion suggestions
#347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickie
approved these changes
Nov 18, 2022
| } | ||
|
|
||
| /** | ||
| * Uses {@link SourceCode#deleteWithTrailingWhitespace(Tree, VisitorState)} to suggest the |
There was a problem hiding this comment.
For all @BugPatterns we start with A {@link BugChecker} that, so would suggest to do the same here.
Stephan202
force-pushed
the
sschroevers/avoid-empty-lines-at-start-of-code-block
branch
from
fcf3521 to
defbb27
Compare
Stephan202
commented
Nov 19, 2022
|
Oops, I don't know what happened but thanks for applying 😉. |
Stephan202
commented
Nov 19, 2022
Comment on lines
56
to
59
| int actualEnd = NON_WHITESPACE_MATCHER.indexIn(sourceCode, endPos); | ||
| return actualEnd == -1 | ||
| ? SuggestedFix.delete(tree) | ||
| : SuggestedFix.replace(((DiagnosticPosition) tree).getStartPosition(), actualEnd, ""); |
There was a problem hiding this comment.
Not that I think we ever hit this case, but I think we should use sourceCode.length() if actualEnd == -1.
There was a problem hiding this comment.
Rebased and added a commit.
When suggesting to remove a method or method annotation, also remove any trailing whitespace. This avoids the possible introduction of an empty line right at the start of a code block.
Stephan202
force-pushed
the
sschroevers/avoid-empty-lines-at-start-of-code-block
branch
from
defbb27 to
bdb60ee
Compare
rickie
deleted the
sschroevers/avoid-empty-lines-at-start-of-code-block
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested commit message:
See also this comment.