Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update all tests to use text blocks #198

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Update all tests to use text blocks #198

wants to merge 5 commits into from

Conversation

Stephan202
Copy link
Member

@Stephan202 Stephan202 commented Aug 14, 2022 •
edited
Loading

Edit: PR #603 was spun off from this PR. That change should be merged and finalized first.

Suggested commit message:

Update all tests to use text blocks (#198)

All `CompilationTestHelper` and `BugCheckerRefactoringTestHelper` test
code is now specified using a single text block. These changes were
automated thanks to the new text block support added to the 
`ErrorProneTestHelperSourceFormat` check, now renamed to
`TestHelperSourceFormat`.

Stephan202
Stephan202 commented Aug 14, 2022
View reviewed changes
error-prone-contrib/README.md Outdated
Comment on lines 36 to 45
When running the project's tests in IntelliJ IDEA, you might see the following
error:
```
java: exporting a package from system module jdk.compiler is not allowed with --release
```

If this happens, go to _Settings -> Build, Execution, Deployment -> Compiler ->
Java Compiler_ and deselect the option _Use '--release' option for
cross-compilation (Java 9 and later)_. See [IDEA-288052][idea-288052] for
details.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new idea Maven profile "somehow" makes IDEA behave as desired. We'll need to re-test this before merging.

...prone-contrib/src/test/java/tech/picnic/errorprone/bugpatterns/AmbiguousJsonCreatorTest.java Show resolved Hide resolved
...prone-contrib/src/test/java/tech/picnic/errorprone/bugpatterns/AmbiguousJsonCreatorTest.java Outdated Show resolved Hide resolved
@Stephan202 Stephan202 force-pushed the sschroevers/jdk-17-tests branch from c23e387 to 201ea7c Compare August 14, 2022 19:57
Base automatically changed from sschroevers/drop-javac-dependency to master September 5, 2022 14:11
@Stephan202 Stephan202 force-pushed the sschroevers/jdk-17-tests branch 7 times, most recently from 7640841 to 5d77f90 Compare September 6, 2022 15:59
@Stephan202 Stephan202 force-pushed the sschroevers/jdk-17-tests branch 2 times, most recently from 2bc0460 to a1c93b0 Compare September 18, 2022 14:18
@Stephan202 Stephan202 mentioned this pull request Nov 13, 2022
Merged
@Stephan202
Copy link
Member Author

Rebased and resolved conflicts.

@Stephan202 Stephan202 force-pushed the sschroevers/jdk-17-tests branch from 8f33dd8 to 6d70c51 Compare November 13, 2022 13:23
@Stephan202 Stephan202 mentioned this pull request Dec 31, 2022
Closed
@Stephan202 Stephan202 mentioned this pull request Jan 22, 2023
Open
@Stephan202 Stephan202 mentioned this pull request Feb 28, 2023
Closed
@Stephan202 Stephan202 force-pushed the sschroevers/jdk-17-tests branch 5 times, most recently from 6acef3e to 86d094f Compare March 4, 2023 17:31
@PicnicSupermarket PicnicSupermarket deleted a comment from github-actions bot Mar 4, 2023
@PicnicSupermarket PicnicSupermarket deleted a comment from github-actions bot Mar 4, 2023
@PicnicSupermarket PicnicSupermarket deleted a comment from github-actions bot Mar 4, 2023
@PicnicSupermarket PicnicSupermarket deleted a comment from github-actions bot Mar 4, 2023
@PicnicSupermarket PicnicSupermarket deleted a comment from github-actions bot Mar 4, 2023
@Stephan202 Stephan202 added this to the 0.16.0 milestone Feb 11, 2024
@Stephan202 Stephan202 force-pushed the sschroevers/jdk-17-tests branch from 42ebd8e to 6221fc9 Compare February 11, 2024 16:50
@Stephan202
Copy link
Member Author

Rebased and resolved conflicts and other issues. The PR now targets master. Next up would be to get the code in a reviewable state, primarily by extending test coverage. One other key decision to make, is whether to keep support for the "don't use text blocks" mode. During development this has been very helpful, so perhaps we should keep it for now, but over time I expect that this functionality will become disused. (Though I suppose it'll simplify contributing checks upstream.)

NB: I added a commit with a proposal to rename the check. I've updated the suggested commit message accordingly.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 11, 2024

Quality Gate Passed Quality Gate passed

Issues
6 New issues

Measures
0 Security Hotspots
87.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link

  • Surviving mutants in this change: 33
  • Killed mutants in this change: 74
class surviving killed
🧟tech.picnic.errorprone.guidelines.bugpatterns.TestHelperSourceFormat 31 68
🧟tech.picnic.errorprone.utils.SourceCode 2 6

Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@rickie rickie modified the milestones: 0.16.0, 0.17.0 Mar 8, 2024
@Stephan202 Stephan202 force-pushed the sschroevers/jdk-17-tests branch 2 times, most recently from 167f021 to 4519571 Compare March 17, 2024 11:39
@github-actions GitHub Actions
Copy link

  • Surviving mutants in this change: 33
  • Killed mutants in this change: 74
class surviving killed
🧟tech.picnic.errorprone.guidelines.bugpatterns.TestHelperSourceFormat 31 68
🧟tech.picnic.errorprone.utils.SourceCode 2 6

Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@Stephan202
Update all tests to use text blocks
eb04678 
All `CompilationTestHelper` and `BugCheckerRefactoringTestHelper` test
code is now specified using a single text block. These changes were
automated thanks to the new text block support added to the
`ErrorProneTestHelperSourceFormat` check.
@Stephan202
Proposal: rename check
3f837bb
@Stephan202
Use text blocks
ff32f63
@Stephan202
WIP
61120c7
@Stephan202 Stephan202 force-pushed the sschroevers/jdk-17-tests branch from 4519571 to 61120c7 Compare March 23, 2024 20:06
@github-actions GitHub Actions
Copy link

  • Surviving mutants in this change: 38
  • Killed mutants in this change: 71
class surviving killed
🧟tech.picnic.errorprone.guidelines.bugpatterns.TestHelperSourceFormat 31 63
🧟tech.picnic.errorprone.utils.SourceCode 7 6
🎉tech.picnic.errorprone.documentation.BugPatternTestExtractor$BugPatternTestCollector 0 2

Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@Stephan202 Stephan202 force-pushed the sschroevers/jdk-17-tests branch from 51cd85c to e735164 Compare March 23, 2024 22:05
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 23, 2024

Quality Gate Passed Quality Gate passed

Issues
7 New issues
0 Accepted issues

Measures
0 Security Hotspots
79.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link

  • Surviving mutants in this change: 38
  • Killed mutants in this change: 71
class surviving killed
🧟tech.picnic.errorprone.guidelines.bugpatterns.TestHelperSourceFormat 31 63
🧟tech.picnic.errorprone.utils.SourceCode 7 6
🎉tech.picnic.errorprone.documentation.BugPatternTestExtractor$BugPatternTestCollector 0 2

Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

1 similar comment
@github-actions GitHub Actions
Copy link

  • Surviving mutants in this change: 38
  • Killed mutants in this change: 71
class surviving killed
🧟tech.picnic.errorprone.guidelines.bugpatterns.TestHelperSourceFormat 31 63
🧟tech.picnic.errorprone.utils.SourceCode 7 6
🎉tech.picnic.errorprone.documentation.BugPatternTestExtractor$BugPatternTestCollector 0 2

Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@Stephan202 Stephan202 modified the milestones: 0.17.0, 0.18.0 Jul 20, 2024
@rickie rickie modified the milestones: 0.18.0, 0.19.0 Aug 7, 2024
@rickie rickie mentioned this pull request Sep 16, 2024
Merged
@rickie rickie modified the milestones: 0.19.0, 0.20.0 Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickie rickie rickie left review comments

@devarmenchik1408 devarmenchik1408 devarmenchik1408 approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
improvement
Milestone
0.20.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Stephan202 @rickie @devarmenchik1408