-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require JDK 17 rather than JDK 11 #603
Conversation
db67feb
to
9c61a7d
Compare
Open points (will circle back to this PR over the coming days):
|
I filed bsideup/jabel#177 for the JDK 20 build error. (We should also update the GitHub Actions workflow to use the latest JDK 20 release, but I'll open a separate PR for that.) |
Filed #604. |
9c61a7d
to
aa78360
Compare
Rebased PR on top of #604. |
eeae7c2
to
c52841e
Compare
Updated the branch. The SonarCloud alerts have been resolved. I verified that all surviving mutations reported by Pitest are also present on the target branch; resolving those is out of scope. The only open point is the Jabel JDK 20 incompatibility; let's wait for a few days to see whether we can get a new release for that. Alternatively we can temporarily disable the JDK 20 build. |
921801d
to
7b9ef35
Compare
c52841e
to
0ccbf97
Compare
7fdbd0d
to
6ed8caf
Compare
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I rebased and added two more small commits, introducing a few more text blocks (and thus resolving some more SonarCloud violations).
I'll merge once built, so that I can start rebasing other PRs. (@rickie I realize that this skips a review opportunity; happy to open follow-up PRs.)
String.format( | ||
"Rule `%s` matches on line %s, while it should match in a method named `test%s`.", | ||
e.getValue(), e.getKey(), e.getValue())) | ||
""" | ||
Rule `%s` matches on line %s, while it should match in a method named \ | ||
`test%s`.""" | ||
.formatted(e.getValue(), e.getKey(), e.getValue())) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't use .formatted
elsewhere, but i.c.w. text blocks it makes sense. Let's review whether we want to switch all String.format
usages.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed. |
❗
This PR is on top of #604. ❗ This now targetsmaster
.This PR is spun off from #198. The idea is that it is merged first; the scope of #198 is then reduced to text block support for
CompilationTestHelper
andBugCheckerRefactoringTestHelper
.❗ A lot of discussion in this PR was around use of Jabel. This turned out to cause flaky GitHub Actions builds, so eventually we decided to simply raise the project's baseline to JDK 17. This was the now obsolete suggested commit message:
New suggested commit message: