-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support JDK 20 and JDK 21 #177
Support JDK 20 and JDK 21 #177
Conversation
@bsideup would you have time to review this small PR? I'd like to introduce this library in a project that (a.o.) builds against JDK 20 (see PicnicSupermarket/error-prone-support#603), but without these changes our build fails. |
It would help us enormously if this PR could be reviewed and merged 😄. Could you take a look at this? @bsideup |
At this point, it might be better to switch to https://github.com/RaphiMC/JavaDowngrader |
Tnx for sharing @NebelNidas! On cursory inspection of that project, it doesn't appear to provide a @bsideup I'm sure you're super busy; if there's anything else we can do to get this merged/released (perhaps deferring review to another dev you trust with this task?), do let us know. ❤️ |
From JDK 20 onwards the `LAMBDA` feature enum constant is no longer recognized. Falling back to the `RECORDS` enum constant should guarantee support for the next few JDK releases. Upgrading Byte Buddy from 1.12.18 to 1.14.9 introduces Java 21 byte code support.
06777ca
to
3ee382f
Compare
Rebased and updated the PR (including the PR description). It turns out that JDK 21 compatibility also required upgrading Byte Buddy, so I added that to the change set. As best as I can tell this makes the plugin compatible with JDK 20 and JDK 21. |
Hi everyone! I apologize for missing this PR (thank you @asolntsev for the ping!). I just merged it and will release a new version ASAP. @Stephan202 thank you for your contribution (and consistency!) |
Thanks for releasing version 1.0.1, @bsideup! I know Maven Central syncing can take a few hours, and that therefore release may not yet be visible here, but a direct download also yields an HTTP 404 response. Could it be that the artifacts have have yet to be published? |
Hey @bsideup! I see that the artifact is still not on Maven Central. Can you please have a look? 🙏 |
^ @sergeykad just filed a separate issue for this: #182. (Tnx!) |
This PR aims to resolve the following error when building with JDK 20 (which I hit while working on PicnicSupermarket/error-prone-support#603):
This PR also resolves the following error when using JDK 21:
I hope that this change matches the spirit of what
CheckSourceLevelAdvice
is meant to do 🤞.Suggested commit message: