Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade version.error-prone 2.9.0 -> 2.10.0 #175

Merged
merged 2 commits into from
Apr 17, 2022
Merged

Upgrade version.error-prone 2.9.0 -> 2.10.0 #175

merged 2 commits into from
Apr 17, 2022

Conversation

Picnic-Bot
Copy link
Contributor

@Picnic-Bot Picnic-Bot commented Nov 8, 2021 •
edited
Loading

@Picnic-Bot Picnic-Bot added the dependencies Pull requests that update a dependency file label Nov 8, 2021
@Picnic-Bot
Copy link
Contributor Author

Suggested commit message:

Upgrade Error Prone 2.9.0 -> 2.10.0

See:
- https://github.com/google/error-prone/releases/tag/v2.10.0
- https://github.com/google/error-prone/compare/v2.9.0...v2.10.0

@Picnic-Bot Picnic-Bot force-pushed the renovate/version.error-prone branch from cced003 to c885835 Compare November 26, 2021 04:31
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Stephan202 Stephan202 added this to the 0.0.4 milestone Jan 5, 2022
Stephan202
Stephan202 approved these changes Jan 5, 2022
View reviewed changes
Copy link
Member

@Stephan202 Stephan202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a commit to disable two checks; we've also disabled these internally.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Stephan202 Stephan202 mentioned this pull request Apr 16, 2022
Merged
@Stephan202 Stephan202 force-pushed the renovate/version.error-prone branch from 6e916e4 to a1e8efc Compare April 16, 2022 13:14
Stephan202
Stephan202 reviewed Apr 16, 2022
View reviewed changes
Copy link
Member

@Stephan202 Stephan202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased and resolved conflict.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

rickie
rickie approved these changes Apr 17, 2022
View reviewed changes
pom.xml
Deals with an Android-specific limitation
not applicable to us. See also
https://github.com/google/error-prone/issues/488.
--> -Xep:StaticOrDefaultInterfaceMethod:OFF <!--
XXX: This check flags false positives.
See https://github.com/google/error-prone/issues/2679.
--> -Xep:VoidMissingNullable:OFF <!--
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bit weird how the --> and <-- are on the same line as the checks are disabled. We don't have that internally, is there a specific reason for that?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See this documentation. This formatting is a remnant of our support for JDK 8. I plan to open one or more PRs to sync internal Maven parent improvements to this repo; will then also clean this up.

@rickie rickie removed the request for review from nathankooij April 17, 2022 11:43
@Stephan202 Stephan202 merged commit 6ea9436 into master Apr 17, 2022
@Stephan202 Stephan202 deleted the renovate/version.error-prone branch April 17, 2022 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stephan202 Stephan202 Stephan202 approved these changes

@ferdinand-swoboda ferdinand-swoboda ferdinand-swoboda approved these changes

@rickie rickie rickie approved these changes

@hisener hisener hisener approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Milestone
0.0.4
Development

Successfully merging this pull request may close these issues.
5 participants
@Picnic-Bot @Stephan202 @hisener @rickie @ferdinand-swoboda