Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade version.error-prone 2.9.0 -> 2.10.0 #175

Merged
merged 2 commits into from
Apr 17, 2022
Merged

Upgrade version.error-prone 2.9.0 -> 2.10.0 #175

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6c0fc7f
Upgrade version.error-prone 2.9.0 -> 2.10.0
Picnic-Bot Nov 26, 2021
a1e8efc
Disable selected new checks
Stephan202 Jan 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@
<error-prone.args />
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<version.auto-service>1.0.1</version.auto-service>
<version.error-prone>2.9.0</version.error-prone>
<version.error-prone>2.10.0</version.error-prone>
<version.error-prone-javac>9+181-r4173-1</version.error-prone-javac>
<version.guava-beta-checker>1.0</version.guava-beta-checker>
<version.immutables>2.8.8</version.immutables>
Expand Down Expand Up @@ -1010,10 +1010,15 @@
--> -Xep:AndroidJdkLibsChecker:OFF <!--
We don't target JDK 7.
--> -Xep:Java7ApiChecker:OFF <!--
We don't target JDK 8.
--> -Xep:Java8ApiChecker:OFF <!--
Deals with an Android-specific limitation
not applicable to us. See also
https://github.com/google/error-prone/issues/488.
--> -Xep:StaticOrDefaultInterfaceMethod:OFF <!--
XXX: This check flags false positives.
See https://github.com/google/error-prone/issues/2679.
--> -Xep:VoidMissingNullable:OFF <!--
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bit weird how the --> and <-- are on the same line as the checks are disabled. We don't have that internally, is there a specific reason for that?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See this documentation. This formatting is a remnant of our support for JDK 8. I plan to open one or more PRs to sync internal Maven parent improvements to this repo; will then also clean this up.

--> -XepOpt:NullAway:AnnotatedPackages=tech.picnic <!--
--> -XepOpt:NullAway:AssertsEnabled=true <!--
Append additional custom arguments.
Expand Down